You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2022/12/07 06:07:30 UTC

[GitHub] [incubator-teaclave] henrysun007 opened a new pull request, #666: Upgrade to Rust SGX SDK 2.0.0

henrysun007 opened a new pull request, #666:
URL: https://github.com/apache/incubator-teaclave/pull/666

   ## Description
   
   Upgrade Rust toolchain and SGX software.
   
   Fixes # (issue)
   
   https://github.com/apache/incubator-teaclave/issues/664
   https://github.com/apache/incubator-teaclave/issues/662
   
   ## Type of change (select or add applied and delete the others)
   
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] API change with a documentation update
   - [ ] Additional test coverage
   - [ ] Code cleanup or just sync with upstream third-party crates
   
   ## How has this been tested?
   CI and local HW tests.
   
   ## Checklist
   
   - [X] Fork the repo and create your branch from `master`.
   - [ ] If you've added code that should be tested, add tests.
   - [ ] If you've changed APIs, update the documentation.
   - [X] Ensure the tests pass (see CI results).
   - [X] Make sure your code lints/format.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] henrysun007 commented on pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
henrysun007 commented on PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666#issuecomment-1358745661

   Just talked with @volcano0dr. The sgx_tprotected_fs may need time to support ios/mac. We cannot support ios/mac in this PR and will use the support when it is ready in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] henrysun007 commented on a diff in pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
henrysun007 commented on code in PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666#discussion_r1043083301


##########
.github/workflows/ci.yml:
##########
@@ -45,14 +45,15 @@ jobs:
           cd sdk/swift/TeaclaveClientSDK && xcodebuild -scheme TeaclaveClientSDK
   format:
     runs-on: ubuntu-20.04
-    container: teaclave/teaclave-build-ubuntu-1804-sgx-2.14:0.1.5
+    container: ghcr.io/henrysun007/teaclave-build-ubuntu-2004-sgx-2.17.1:upgrade

Review Comment:
   I was added to `teaclave` org, but seem to have no enough permission to create new repos.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] mssun commented on pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
mssun commented on PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666#issuecomment-1363619719

   > @mssun I cannot open PR to https://github.com/apache/incubator-teaclave-crates as it is empty. So I pushed the crates to https://github.com/mesatee/crates. The code is tested. You can upload the code directly to `incubator-teaclave-crates`. Let me know after the upload.
   
   I created a README.md file. You can now submit PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] henrysun007 commented on a diff in pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
henrysun007 commented on code in PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666#discussion_r1043083301


##########
.github/workflows/ci.yml:
##########
@@ -45,14 +45,15 @@ jobs:
           cd sdk/swift/TeaclaveClientSDK && xcodebuild -scheme TeaclaveClientSDK
   format:
     runs-on: ubuntu-20.04
-    container: teaclave/teaclave-build-ubuntu-1804-sgx-2.14:0.1.5
+    container: ghcr.io/henrysun007/teaclave-build-ubuntu-2004-sgx-2.17.1:upgrade

Review Comment:
   I was added to `teaclave` org, but seem to have no permission to create new repos.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] henrysun007 commented on pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
henrysun007 commented on PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666#issuecomment-1363600746

   @mssun I cannot open PR to https://github.com/apache/incubator-teaclave-crates as it is empty. So I pushed the crates to https://github.com/mesatee/crates. The code is tested. You can upload the code directly to `incubator-teaclave-crates`. Let me know after the upload.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] mssun merged pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
mssun merged PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] henrysun007 commented on a diff in pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
henrysun007 commented on code in PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666#discussion_r1043083301


##########
.github/workflows/ci.yml:
##########
@@ -45,14 +45,15 @@ jobs:
           cd sdk/swift/TeaclaveClientSDK && xcodebuild -scheme TeaclaveClientSDK
   format:
     runs-on: ubuntu-20.04
-    container: teaclave/teaclave-build-ubuntu-1804-sgx-2.14:0.1.5
+    container: ghcr.io/henrysun007/teaclave-build-ubuntu-2004-sgx-2.17.1:upgrade

Review Comment:
   I was added to `teaclave` org, but seem to have not enough permission to create new repos.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] mssun commented on a diff in pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
mssun commented on code in PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666#discussion_r1042906049


##########
.github/workflows/ci.yml:
##########
@@ -45,14 +45,15 @@ jobs:
           cd sdk/swift/TeaclaveClientSDK && xcodebuild -scheme TeaclaveClientSDK
   format:
     runs-on: ubuntu-20.04
-    container: teaclave/teaclave-build-ubuntu-1804-sgx-2.14:0.1.5
+    container: ghcr.io/henrysun007/teaclave-build-ubuntu-2004-sgx-2.17.1:upgrade

Review Comment:
   I'll add you to the `teaclave` org in DockerHub. Let's use this org to host the image.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] henrysun007 commented on a diff in pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
henrysun007 commented on code in PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666#discussion_r1043083301


##########
.github/workflows/ci.yml:
##########
@@ -45,14 +45,15 @@ jobs:
           cd sdk/swift/TeaclaveClientSDK && xcodebuild -scheme TeaclaveClientSDK
   format:
     runs-on: ubuntu-20.04
-    container: teaclave/teaclave-build-ubuntu-1804-sgx-2.14:0.1.5
+    container: ghcr.io/henrysun007/teaclave-build-ubuntu-2004-sgx-2.17.1:upgrade

Review Comment:
   I was added to `teaclave` organization in docker Hub, but seem to have no permission to create new repos.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] henrysun007 commented on pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
henrysun007 commented on PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666#issuecomment-1363630612

   Cool. The PR is submitted. @mssun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] volcano0dr commented on pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
volcano0dr commented on PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666#issuecomment-1340581277

   Rust SGX SDK 2.0.0 has implemented [sgx_protected_fs](https://github.com/apache/incubator-teaclave-sgx-sdk/tree/v2.0.0-preview/sgx_protected_fs) with Rust, and can support the use inside and outside the Enclave. I think you can replace [protected_fs_rs](https://github.com/apache/incubator-teaclave/tree/master/common/protected_fs_rs) with sgx_protected_fs in 2.0.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] mssun commented on a diff in pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
mssun commented on code in PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666#discussion_r1045434998


##########
.github/workflows/ci.yml:
##########
@@ -45,14 +45,15 @@ jobs:
           cd sdk/swift/TeaclaveClientSDK && xcodebuild -scheme TeaclaveClientSDK
   format:
     runs-on: ubuntu-20.04
-    container: teaclave/teaclave-build-ubuntu-1804-sgx-2.14:0.1.5
+    container: ghcr.io/henrysun007/teaclave-build-ubuntu-2004-sgx-2.17.1:upgrade

Review Comment:
   I have invited you as the admin. Can you try again? Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] mssun commented on a diff in pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
mssun commented on code in PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666#discussion_r1049197265


##########
.github/workflows/ci.yml:
##########
@@ -45,14 +45,15 @@ jobs:
           cd sdk/swift/TeaclaveClientSDK && xcodebuild -scheme TeaclaveClientSDK
   format:
     runs-on: ubuntu-20.04
-    container: teaclave/teaclave-build-ubuntu-1804-sgx-2.14:0.1.5
+    container: ghcr.io/henrysun007/teaclave-build-ubuntu-2004-sgx-2.17.1:upgrade

Review Comment:
   I have added you as the owner. Please try again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave] henrysun007 commented on a diff in pull request #666: Upgrade to Rust SGX SDK 2.0.0

Posted by GitBox <gi...@apache.org>.
henrysun007 commented on code in PR #666:
URL: https://github.com/apache/incubator-teaclave/pull/666#discussion_r1049417165


##########
.github/workflows/ci.yml:
##########
@@ -45,14 +45,15 @@ jobs:
           cd sdk/swift/TeaclaveClientSDK && xcodebuild -scheme TeaclaveClientSDK
   format:
     runs-on: ubuntu-20.04
-    container: teaclave/teaclave-build-ubuntu-1804-sgx-2.14:0.1.5
+    container: ghcr.io/henrysun007/teaclave-build-ubuntu-2004-sgx-2.17.1:upgrade

Review Comment:
   The pushing succeeded this time. Thanks, mingshen.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org