You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/12/09 13:45:28 UTC
[GitHub] [servicecomb-java-chassis] wujimin opened a new pull request #2115: [SCB-2154] fix Response.isSuccessed typo
wujimin opened a new pull request #2115:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2115
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] wujimin merged pull request #2115: [SCB-2154] fix Response.isSuccessed typo
Posted by GitBox <gi...@apache.org>.
wujimin merged pull request #2115:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-io commented on pull request #2115: [SCB-2154] fix Response.isSuccessed typo
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2115:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2115#issuecomment-741795863
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115?src=pr&el=h1) Report
> Merging [#2115](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115?src=pr&el=desc) (8ac7f0c) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/751f75d804e22b5a9ebd96f47caa695bde99d841?el=desc) (751f75d) will **decrease** coverage by `0.01%`.
> The diff coverage is `44.44%`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2115 +/- ##
============================================
- Coverage 80.88% 80.86% -0.02%
Complexity 1335 1335
============================================
Files 1456 1456
Lines 39925 39926 +1
Branches 3387 3387
============================================
- Hits 32293 32288 -5
- Misses 6164 6170 +6
Partials 1468 1468
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rvicecomb/core/provider/consumer/InvokerUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9wcm92aWRlci9jb25zdW1lci9JbnZva2VyVXRpbHMuamF2YQ==) | `70.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ecomb/transport/rest/client/RestClientDecoder.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115/diff?src=pr&el=tree#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3RyYW5zcG9ydC9yZXN0L2NsaWVudC9SZXN0Q2xpZW50RGVjb2Rlci5qYXZh) | `4.54% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../org/apache/servicecomb/provider/pojo/Invoker.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115/diff?src=pr&el=tree#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXBvam8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Byb3ZpZGVyL3Bvam8vSW52b2tlci5qYXZh) | `80.64% <50.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mvc/reference/async/CseAsyncClientHttpRequest.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115/diff?src=pr&el=tree#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXNwcmluZ212Yy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcHJvdmlkZXIvc3ByaW5nbXZjL3JlZmVyZW5jZS9hc3luYy9Dc2VBc3luY0NsaWVudEh0dHBSZXF1ZXN0LmphdmE=) | `91.66% <50.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/servicecomb/swagger/invocation/Response.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115/diff?src=pr&el=tree#diff-c3dhZ2dlci9zd2FnZ2VyLWludm9jYXRpb24vaW52b2NhdGlvbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9zd2FnZ2VyL2ludm9jYXRpb24vUmVzcG9uc2UuamF2YQ==) | `88.57% <50.00%> (-1.29%)` | `0.00 <0.00> (ø)` | |
| [...ider/springmvc/reference/CseClientHttpRequest.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115/diff?src=pr&el=tree#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXNwcmluZ212Yy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcHJvdmlkZXIvc3ByaW5nbXZjL3JlZmVyZW5jZS9Dc2VDbGllbnRIdHRwUmVxdWVzdC5qYXZh) | `87.80% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/servicecomb/config/kie/client/KieClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115/diff?src=pr&el=tree#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWtpZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvS2llQ2xpZW50LmphdmE=) | `72.61% <0.00%> (-5.96%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115?src=pr&el=footer). Last update [751f75d...8ac7f0c](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2115?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org