[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8874: Use multi-stage DataBlock as DataTableImplV4

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #8874:
URL: https://github.com/apache/pinot/pull/8874#discussion_r897031706


##########
pinot-core/src/main/java/org/apache/pinot/core/common/datablock/DataBlockUtils.java:
##########
@@ -37,11 +37,6 @@ private DataBlockUtils() {
   static {
     EOS_DATA_BLOCK._metadata.put(DataTable.MetadataKey.TABLE.getName(), "END_OF_STREAM");
   }
-  private static final TransferableBlock EOS_TRANSFERABLE_BLOCK = new TransferableBlock(EOS_DATA_BLOCK);
-
-  public static TransferableBlock getEndOfStreamTransferableBlock() {
-    return EOS_TRANSFERABLE_BLOCK;
-  }
 
   public static MetadataBlock getEndOfStreamDataBlock() {

Review Comment:
   In the current data table, the error block has no data schema. Any reason why we put an empty one in the new version?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org