You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2019/04/06 11:17:47 UTC

[hbase] branch branch-2.1 updated: HBASE-22174 Remove error prone from our precommit javac check

This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2.1 by this push:
     new 5fdc4fb  HBASE-22174 Remove error prone from our precommit javac check
5fdc4fb is described below

commit 5fdc4fb43716a68c96c3ce1ea04fdd90f7cea43f
Author: zhangduo <zh...@apache.org>
AuthorDate: Sat Apr 6 13:51:02 2019 +0800

    HBASE-22174 Remove error prone from our precommit javac check
---
 dev-support/Jenkinsfile_GitHub   | 1 +
 dev-support/hbase-personality.sh | 5 ++++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/dev-support/Jenkinsfile_GitHub b/dev-support/Jenkinsfile_GitHub
index 4d08f3e..0188ecd 100644
--- a/dev-support/Jenkinsfile_GitHub
+++ b/dev-support/Jenkinsfile_GitHub
@@ -153,6 +153,7 @@ pipeline {
                         YETUS_ARGS+=("--whitespace-tabs-ignore-list=.*/generated/.*")
                         YETUS_ARGS+=("--personality=${SOURCEDIR}/dev-support/hbase-personality.sh")
                         YETUS_ARGS+=("--quick-hadoopcheck")
+                        YETUS_ARGS+=("--skip-errorprone")
                         # effectively treat dev-support as a custom maven module
                         YETUS_ARGS+=("--skip-dir=dev-support")
                         # help keep the ASF boxes clean
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index e5ccea0..9cab756 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -94,6 +94,9 @@ function personality_parse_args
       --hadoop-profile=*)
         HADOOP_PROFILE=${i#*=}
       ;;
+      --skip-errorprone)
+        SKIP_ERRORPRONE=true
+      ;;
     esac
   done
 }
@@ -165,7 +168,7 @@ function personality_modules
     return
   fi
 
-  if [[ ${testtype} == compile ]]; then
+  if [[ ${testtype} == compile ]] && [[ "${SKIP_ERRORPRONE}" != "true" ]]; then
     extra="${extra} -PerrorProne"
   fi