[GitHub] [incubator-doris] morningman commented on a change in pull request #5521: [Colocate plan][Step1] Colocate join covers more situations

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #5521:
URL: https://github.com/apache/incubator-doris/pull/5521#discussion_r601037722



##########
File path: fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java
##########
@@ -781,11 +782,16 @@ public void releaseBackends(String clusterName, boolean isReplay) {
             }
         }
 
+
         // if more than one backend exists in same host, select a backend at random
         List<Backend> backends = Lists.newArrayList();
         for (List<Backend> list : backendMaps.values()) {
-            Collections.shuffle(list);
-            backends.add(list.get(0));
+            if (FeConstants.runningUnitTest) {
+                backends.addAll(list);

Review comment:
       why add all?

##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java
##########
@@ -1334,7 +1334,26 @@ public Type castBinaryOp(Type compatibleType) throws AnalysisException {
     @Override
     public String toString() {
         return MoreObjects.toStringHelper(this.getClass()).add("id", id).add("type", type).add("sel",
-          selectivity).add("#distinct", numDistinctValues).add("scale", outputScale).toString();
+                selectivity).add("#distinct", numDistinctValues).add("scale", outputScale).toString();
+    }
+
+    public SlotRef getSrcSlotRef() {

Review comment:
       add some comment

##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -235,8 +235,8 @@
     @VariableMgr.VarAttr(name = DISABLE_STREAMING_PREAGGREGATIONS)
     public boolean disableStreamPreaggregations = false;
 
-    @VariableMgr.VarAttr(name = DISABLE_COLOCATE_JOIN)
-    public boolean disableColocateJoin = false;
+    @VariableMgr.VarAttr(name = DISABLE_COLOCATE_PLAN)
+    public boolean disableColocatePlan = false;

Review comment:
       Why changing the name?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org