You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2023/09/19 02:15:36 UTC

[GitHub] [iotdb] JackieTien97 opened a new pull request, #11178: [IOTDB-6164] Fix create illegal path through rest api bug

JackieTien97 opened a new pull request, #11178:
URL: https://github.com/apache/iotdb/pull/11178

   After this pr, we  will get error msg while using illegal path
   <img width="1827" alt="image" src="https://github.com/apache/iotdb/assets/16079446/83b634c7-6175-4bbb-b324-dda8680802d3">
   And we must use \`\` to include the path to be successful.
   <img width="1870" alt="image" src="https://github.com/apache/iotdb/assets/16079446/2982dcef-d9c1-43a7-a497-07bcf02d3716">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] codecov-commenter commented on pull request #11178: [IOTDB-6164] Fix create illegal path through rest api bug

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11178:
URL: https://github.com/apache/iotdb/pull/11178#issuecomment-1724766668

   ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#11178](https://app.codecov.io/gh/apache/iotdb/pull/11178?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d4e3e93) into [master](https://app.codecov.io/gh/apache/iotdb/commit/1aa098cda937c4e0fbc69f11b3a72d16a3d8d82a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1aa098c) will **decrease** coverage by `0.03%`.
   > Report is 2 commits behind head on master.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11178      +/-   ##
   ============================================
   - Coverage     47.57%   47.55%   -0.03%     
   + Complexity    23628    23625       -3     
   ============================================
     Files          2788     2788              
     Lines        170312   170388      +76     
     Branches      20294    20302       +8     
   ============================================
     Hits          81032    81032              
   - Misses        89280    89356      +76     
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/iotdb/pull/11178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...node/manager/pipe/runtime/PipeHeartbeatParser.java](https://app.codecov.io/gh/apache/iotdb/pull/11178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvcGlwZS9ydW50aW1lL1BpcGVIZWFydGJlYXRQYXJzZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...onfignode/manager/pipe/runtime/PipeMetaSyncer.java](https://app.codecov.io/gh/apache/iotdb/pull/11178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvcGlwZS9ydW50aW1lL1BpcGVNZXRhU3luY2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...fignode/manager/pipe/task/PipeTaskCoordinator.java](https://app.codecov.io/gh/apache/iotdb/pull/11178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvcGlwZS90YXNrL1BpcGVUYXNrQ29vcmRpbmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ode/manager/pipe/task/PipeTaskCoordinatorLock.java](https://app.codecov.io/gh/apache/iotdb/pull/11178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvcGlwZS90YXNrL1BpcGVUYXNrQ29vcmRpbmF0b3JMb2NrLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...dure/impl/pipe/AbstractOperatePipeProcedureV2.java](https://app.codecov.io/gh/apache/iotdb/pull/11178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL3Byb2NlZHVyZS9pbXBsL3BpcGUvQWJzdHJhY3RPcGVyYXRlUGlwZVByb2NlZHVyZVYyLmphdmE=) | `5.91% <0.00%> (-2.22%)` | :arrow_down: |
   | [.../rest/v1/handler/StatementConstructionHandler.java](https://app.codecov.io/gh/apache/iotdb/pull/11178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcHJvdG9jb2wvcmVzdC92MS9oYW5kbGVyL1N0YXRlbWVudENvbnN0cnVjdGlvbkhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../rest/v2/handler/StatementConstructionHandler.java](https://app.codecov.io/gh/apache/iotdb/pull/11178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcHJvdG9jb2wvcmVzdC92Mi9oYW5kbGVyL1N0YXRlbWVudENvbnN0cnVjdGlvbkhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   
   ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/iotdb/pull/11178/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #11178: [IOTDB-6164] Fix create illegal path through rest api bug

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #11178:
URL: https://github.com/apache/iotdb/pull/11178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #11178: [IOTDB-6164] Fix create illegal path through rest api bug

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #11178:
URL: https://github.com/apache/iotdb/pull/11178#issuecomment-1724737726

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11178)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11178&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11178&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11178&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11178&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11178&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11178&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=11178&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=11178&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=11178&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11178&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11178&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11178&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11178&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11178&metric=new_coverage&view=list)  
   [![66.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/20plus-16px.png '66.7%')](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11178&metric=new_duplicated_lines_density&view=list) [66.7% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11178&metric=new_duplicated_lines_density&view=list)
   
   
   
   ![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png 'idea') Catch issues before they fail your Quality Gate with our IDE extension ![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png 'sonarlint') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org