You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/06 03:26:19 UTC

[GitHub] [iotdb] qiaojialin commented on a change in pull request #2635: [IOTDB-1148]fix the client leak of client pool&use remote schema cache when check timeseries exist or not

qiaojialin commented on a change in pull request #2635:
URL: https://github.com/apache/iotdb/pull/2635#discussion_r571349338



##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/utils/PublicBAOS.java
##########
@@ -61,7 +61,7 @@ public PublicBAOS(int size) {
    * @exception  IOException  if an I/O error occurs.
    */
   @Override
-  public void writeTo(OutputStream out) throws IOException {
+  public synchronized void writeTo(OutputStream out) throws IOException {

Review comment:
       Hi, this is removed on purpose, cause this will impact the Flush pipeline.
   
   See: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=173085039




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org