[jira] [Created] (OFBIZ-11430) getDimensionIdFromNaturalKey should return '_NF_' when no Dimension record found

["Pierre Smits (Jira)" <ji...@apache.org>]

Pierre Smits created OFBIZ-11430:
------------------------------------

             Summary: getDimensionIdFromNaturalKey should return '_NF_' when no Dimension record found
                 Key: OFBIZ-11430
                 URL: https://issues.apache.org/jira/browse/OFBIZ-11430
             Project: OFBiz
          Issue Type: Sub-task
          Components: bi
    Affects Versions: Trunk
            Reporter: Pierre Smits


Currently the 'getDimensionIdFromNaturalKey' function in DimensionServices.java returns the DimensionId when found with following code excerpt
{code:java}
if (UtilValidate.isNotEmpty(lastDimensionValue)) {
            resultMap.put("dimensionId", lastDimensionValue.getString("dimensionId"));
        }
return resultMap;
{code}

And when not found it returns an empty result, leaving the using function upstream to set the '_NF' value. 

The 'getDimensionIdFromNaturalKey' function should return the 'NF' value when no matching dimensionId is found. 

This would simplify the upstream code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)