You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/08/29 20:30:46 UTC
[GitHub] [storm] govind-menon commented on a change in pull request #3121:
STORM-3479 HB timeout configurable on a topology level
govind-menon commented on a change in pull request #3121: STORM-3479 HB timeout configurable on a topology level
URL: https://github.com/apache/storm/pull/3121#discussion_r319258606
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/supervisor/SupervisorUtils.java
##########
@@ -145,6 +146,18 @@ protected LSWorkerHeartbeat readWorkerHeartbeatImpl(Map<String, Object> conf, St
}
private boolean isWorkerHbTimedOutImpl(int now, LSWorkerHeartbeat whb, Map<String, Object> conf) {
- return (now - whb.get_time_secs()) > ObjectReader.getInt(conf.get(Config.SUPERVISOR_WORKER_TIMEOUT_SECS));
+ Integer timeoutSecs;
+ if (conf.containsKey(Config.TOPOLOGY_WORKER_TIMEOUT_SECS)) {
Review comment:
Will there ever be a time when you get the topology conf?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services