You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by dalyssakim <gi...@git.apache.org> on 2017/04/11 02:33:12 UTC
[GitHub] geode pull request #447: Feature/geode 2217
GitHub user dalyssakim opened a pull request:
https://github.com/apache/geode/pull/447
Feature/geode 2217
JIRA : https://issues.apache.org/jira/browse/GEODE-2217
Let me know if we want to change the parameter descriptions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dalyssakim/incubator-geode feature/GEODE-2217
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/447.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #447
----
commit d3c6b339af85d4be78f53bc092049f7849350835
Author: Alyssa Kim <mi...@gmail.com>
Date: 2017-04-11T03:14:12Z
GEODE=2217
Add generic type parameter to FunctionContext interface
commit d9cd09f9a983c1c820be13fbee271c2baaa9cf11
Author: Alyssa Kim <mi...@gmail.com>
Date: 2017-04-11T03:27:07Z
GEODE-2217
Add generic type parameter to FunctionContext interface
Minor change in comments
commit a3ef95d4a6b0fffa775cf9469e5c4e79eec89b77
Author: Alyssa Kim <mi...@gmail.com>
Date: 2017-04-11T03:31:23Z
GEODE-2217
Add generic type parameter to FunctionContext interface
Minor change in comments.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #447: Feature/geode 2217
Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/447
@dalyssakim Can you please do a git fetch and rebase your branch on develop? That should trigger the travis-ci again and pick up the fix that Darrel committed. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #447: Feature/geode 2217
Posted by jhuynh1 <gi...@git.apache.org>.
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/447
I pulled the changes and it built fine. I collapsed and edited the commit messages to match how geode commits generally look and made a minor tweak to the wording on one parameter. This is now in the develop branch of Geode. Thanks (again) for the contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #447: Feature/geode 2217
Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/447
The Travis-CI failures are the NPEs that Darrel's change introduced. He reverted his change so that should resolve these failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #447: Feature/geode 2217
Posted by dalyssakim <gi...@git.apache.org>.
Github user dalyssakim commented on the issue:
https://github.com/apache/geode/pull/447
Thank you so much ! I will make sure I follow geode commits next time :) !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #447: Feature/geode 2217
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/447
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---