You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2018/07/19 21:27:06 UTC

Review Request 67981: HIVE-20196: Separate MetastoreConf into common and server parts

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67981/
-----------------------------------------------------------

Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar.


Bugs: HIVE-20196
    https://issues.apache.org/jira/browse/HIVE-20196


Repository: hive-git


Description
-------

HIVE-20196: Separate MetastoreConf into common and server parts


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java e630e8819a407b7a587d903bad71663803c5bc61 
  standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 47f819b60a6c7eb2acac9217724e67a976341093 
  standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java c2bbba5813c6da568fb55a91c2f95ff050184014 
  standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreServerConf.java PRE-CREATION 
  standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/DelegationTokenTool.java 3637db09f14530a3123a75daf2c12b0cef9c68e2 
  standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/MetaStoreTestUtils.java 3d36b60ec99491b33bce1f9b2d5cf307e4f61ecd 
  standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java cb32236d548ecff58fd190f1f4df8da45a42fa1a 


Diff: https://reviews.apache.org/r/67981/diff/1/


Testing
-------


Thanks,

Alexander Kolbasov


Re: Review Request 67981: HIVE-20196: Remove MetastoreConf dependency on server-specific classes

Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67981/
-----------------------------------------------------------

(Updated Aug. 10, 2018, 6:38 p.m.)


Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar.


Changes
-------

Added unit test to catch class renames.


Bugs: HIVE-20196
    https://issues.apache.org/jira/browse/HIVE-20196


Repository: hive-git


Description
-------

HIVE-20196: Remove MetastoreConf dependency on server-specific classes


Diffs (updated)
-----

  standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java cf5fbbefa6a5b0b7b3443071cce0a76d715e5163 
  standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/conf/TestMetastoreConf.java 1422701be234be98097701f0f58df4eecc5e8838 


Diff: https://reviews.apache.org/r/67981/diff/3/

Changes: https://reviews.apache.org/r/67981/diff/2-3/


Testing
-------


Thanks,

Alexander Kolbasov


Re: Review Request 67981: HIVE-20196: Remove MetastoreConf dependency on server-specific classes

Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67981/
-----------------------------------------------------------

(Updated Aug. 9, 2018, 11:50 p.m.)


Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar.


Changes
-------

Just convert classes to strings.


Summary (updated)
-----------------

HIVE-20196: Remove MetastoreConf dependency on server-specific classes


Bugs: HIVE-20196
    https://issues.apache.org/jira/browse/HIVE-20196


Repository: hive-git


Description (updated)
-------

HIVE-20196: Remove MetastoreConf dependency on server-specific classes


Diffs (updated)
-----

  standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java cf5fbbefa6a5b0b7b3443071cce0a76d715e5163 


Diff: https://reviews.apache.org/r/67981/diff/2/

Changes: https://reviews.apache.org/r/67981/diff/1-2/


Testing
-------


Thanks,

Alexander Kolbasov