[GitHub] [iceberg] szehon-ho edited a comment on pull request #4258: API:Add the usage in javadoc of ValidationException(#3895)

[GitBox <gi...@apache.org>]

szehon-ho edited a comment on pull request #4258:
URL: https://github.com/apache/iceberg/pull/4258#issuecomment-1059416924


   I think it needs a bit more context, how about something like:
   
   
   "Exception raised when validation checks fail.  A ValidationException occurs from inconsistent state that causes an operation to abort, as opposed to an {@link IllegalArgumentException}, which occurs from invalid arguments."
   
   
   I would also love to add another example here:
   
   
   
   "For example, this is thrown when attempting to create a table with a {@link PartitionSpec} that is not compatible with the table {@link Schema}, or attempting to add or remove files to a table that would violate the configured isolation level due to concurrent commits."
   
   
   
   That being said, I did not raise the original issue , so maybe @rdblue @jackye1995 have more thoughts, or @aokolnychyi @RussellSpitzer @kbendick  as well :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org