You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/03/27 01:21:06 UTC

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect 

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9813


Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect
......................................................................

IMPALA-6510: [DOCS] Remove refresh_after_connect

Removed refresh_after_connect option from impala shell options.
Removed the refresh_after_connect from INVALIDATE METADATA doc.

Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0
---
M docs/topics/impala_invalidate_metadata.xml
M docs/topics/impala_shell_options.xml
2 files changed, 0 insertions(+), 29 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/9813/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0
Gerrit-Change-Number: 9813
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 )

Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect
......................................................................


Patch Set 2:

> (1 comment)
 > 
 > LGTM, I think we just don't want this auto-merged to 2.x

Done


-- 
To view, visit http://gerrit.cloudera.org:8080/9813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0
Gerrit-Change-Number: 9813
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 18:14:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 )

Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/9813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0
Gerrit-Change-Number: 9813
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 18:39:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 )

Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/217/


-- 
To view, visit http://gerrit.cloudera.org:8080/9813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0
Gerrit-Change-Number: 9813
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 18:18:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 )

Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect
......................................................................


Patch Set 1:

(1 comment)

LGTM, I think we just don't want this auto-merged to 2.x

http://gerrit.cloudera.org:8080/#/c/9813/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9813/1//COMMIT_MSG@10
PS1, Line 10: Removed the refresh_after_connect from INVALIDATE METADATA doc.
Can we add this line to the commit message to prevent it being merged to the 2.x branch?

     Cherry-picks: not for 2.x



-- 
To view, visit http://gerrit.cloudera.org:8080/9813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0
Gerrit-Change-Number: 9813
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 18:00:28 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9813 )

Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect
......................................................................

IMPALA-6510: [DOCS] Remove refresh_after_connect

Removed refresh_after_connect option from impala shell options.
Removed the refresh_after_connect from INVALIDATE METADATA doc.

Cherry-picks: not for 2.x
Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0
Reviewed-on: http://gerrit.cloudera.org:8080/9813
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_invalidate_metadata.xml
M docs/topics/impala_shell_options.xml
2 files changed, 0 insertions(+), 29 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0
Gerrit-Change-Number: 9813
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 )

Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0
Gerrit-Change-Number: 9813
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 18:18:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 )

Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0
Gerrit-Change-Number: 9813
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 18:18:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 )

Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect
......................................................................


Patch Set 1: Code-Review+1

LGTM subject to Tim's comment about the merging business.


-- 
To view, visit http://gerrit.cloudera.org:8080/9813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0
Gerrit-Change-Number: 9813
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 18:08:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello John Russell, Tim Armstrong, Anonymous Coward #381, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9813

to look at the new patch set (#2).

Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect
......................................................................

IMPALA-6510: [DOCS] Remove refresh_after_connect

Removed refresh_after_connect option from impala shell options.
Removed the refresh_after_connect from INVALIDATE METADATA doc.

Cherry-picks: not for 2.x
Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0
---
M docs/topics/impala_invalidate_metadata.xml
M docs/topics/impala_shell_options.xml
2 files changed, 0 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/9813/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0
Gerrit-Change-Number: 9813
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>