You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by lkishalmi <gi...@git.apache.org> on 2017/10/01 03:49:55 UTC

[GitHub] incubator-netbeans pull request #25: NETBEANS-73: Autodetect id_rsa and id_d...

Github user lkishalmi commented on a diff in the pull request:

    https://github.com/apache/incubator-netbeans/pull/25#discussion_r142020017
  
    --- Diff: git/src/org/netbeans/modules/git/ui/repository/remote/RemoteRepository.java ---
    @@ -686,6 +686,7 @@ public SSHConnectionSettingsType () {
                     settingsPanel.savePasswordCheckBox
                 };
                 acceptableSchemes = EnumSet.of(Scheme.SSH, Scheme.SFTP);
    +            settingsPanel.txtIdentityFile.setText(getDefaultIdentityFilePath());
    --- End diff --
    
    Unfortunately populateFields is not called in every case. Most importantly when the repository URL is being copied from github/gitlab where the ssh:// prefix is just missing from the URL. Probably I could raise a bug on that. And mark this line as a workaround in the code, till it gets fixed. I feel the fix would be a bit out of the trivial category.


---