[jira] [Commented] (HBASE-14117) Check DBEs where fields are being read from Bytebuffers but unused.

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945968#comment-14945968 ] 

stack commented on HBASE-14117:
-------------------------------

What else is to be done here? If it is speculative benefit, move it out as subtask of the parent issue?

> Check DBEs where fields are being read from Bytebuffers but unused.
> -------------------------------------------------------------------
>
>                 Key: HBASE-14117
>                 URL: https://issues.apache.org/jira/browse/HBASE-14117
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Jingcheng Du
>
> {code}
> public Cell getFirstKeyCellInBlock(ByteBuff block) {
>     block.mark();
>     block.position(Bytes.SIZEOF_INT);
>     int keyLength = ByteBuff.readCompressedInt(block);
>     // TODO : See if we can avoid these reads as the read values are not getting used
>     ByteBuff.readCompressedInt(block);
> {code}
> In DBEs many a places we read the integers just to skip them. This JIRA is to see if we can avoid this and rather go position based, as per a review comment in HBASE-12213.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)