You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2022/07/07 16:15:06 UTC
[GitHub] [datasketches-cpp] dyf6372 opened a new pull request, #291: fix comparison bug since type uint8_t is always non-negative
dyf6372 opened a new pull request, #291:
URL: https://github.com/apache/datasketches-cpp/pull/291
The type of `newShiftedVal` is uint8_t, so the condition `newShiftedVal < 0` is always false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on pull request #291: fix comparison bug since type uint8_t is always non-negative
Posted by GitBox <gi...@apache.org>.
jmalkin commented on PR #291:
URL: https://github.com/apache/datasketches-cpp/pull/291#issuecomment-1178535394
It is unrelated to this change.
The Windows python build has an issue affecting all branches currently. It can possibly be resolved by fixing a version of some package but it's not yet clear which one. Alternatively there's a separate issue around what's included in our wheel and it's possible there's now a conflict? Hoping I'll be able to investigate next week.
If everything here works other than the Windows python CI tests we can consider it ok to merge as far as I'm concerned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] coveralls commented on pull request #291: fix comparison bug since type uint8_t is always non-negative
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #291:
URL: https://github.com/apache/datasketches-cpp/pull/291#issuecomment-1178085952
## Pull Request Test Coverage Report for [Build 2630900564](https://coveralls.io/builds/50687496)
* **2** of **2** **(100.0%)** changed or added relevant lines in **1** file are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage decreased (**-0.04%**) to **92.324%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [hll/include/Hll4Array-internal.hpp](https://coveralls.io/builds/50687496/source?filename=hll%2Finclude%2FHll4Array-internal.hpp#L271) | 1 | 91.78% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/50687496) |
| :-- | --: |
| Change from base [Build 2516564597](https://coveralls.io/builds/50133640): | -0.04% |
| Covered Lines: | 2189 |
| Relevant Lines: | 2371 |
---
##### 💛 - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] dyf6372 commented on pull request #291: fix comparison bug since type uint8_t is always non-negative
Posted by GitBox <gi...@apache.org>.
dyf6372 commented on PR #291:
URL: https://github.com/apache/datasketches-cpp/pull/291#issuecomment-1178515809
> I am not sure why Python build on Windows failed
I'm also confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov merged pull request #291: fix comparison bug since type uint8_t is always non-negative
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov merged PR #291:
URL: https://github.com/apache/datasketches-cpp/pull/291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov commented on pull request #291: fix comparison bug since type uint8_t is always non-negative
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on PR #291:
URL: https://github.com/apache/datasketches-cpp/pull/291#issuecomment-1178133770
I am not sure why Python build on Windows failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org