You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2021/04/20 05:31:00 UTC
[jira] [Commented] (SOLR-10502) CurrencyField should
support/default to docvalues for underlying polyfields
[ https://issues.apache.org/jira/browse/SOLR-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325478#comment-17325478 ]
David Smiley commented on SOLR-10502:
-------------------------------------
Tragically / ironically, CurrencyFieldType doesn't support DocValues _either_ :( – SOLR-15358. :face-palm: (Jira needs a face-palm emoji)
> CurrencyField should support/default to docvalues for underlying polyfields
> ---------------------------------------------------------------------------
>
> Key: SOLR-10502
> URL: https://issues.apache.org/jira/browse/SOLR-10502
> Project: Solr
> Issue Type: Improvement
> Reporter: Chris M. Hostetter
> Assignee: Steven Rowe
> Priority: Major
> Fix For: 6.7, 7.0
>
>
> Noticed while working on SOLR-10472, This is currently in {{CurrencyField}} ...
> {code}
> private void createDynamicCurrencyField(String suffix, FieldType type) {
> String name = "*" + POLY_FIELD_SEPARATOR + suffix;
> Map<String, String> props = new HashMap<>();
> props.put("indexed", "true");
> props.put("stored", "false");
> props.put("multiValued", "false");
> props.put("omitNorms", "true");
> int p = SchemaField.calcProps(name, type, props);
> schema.registerDynamicFields(SchemaField.create(name, type, p, null));
> }
> // ...
> @Override
> public void inform(IndexSchema schema) {
> this.schema = schema;
> createDynamicCurrencyField(FIELD_SUFFIX_CURRENCY, fieldTypeCurrency);
> createDynamicCurrencyField(FIELD_SUFFIX_AMOUNT_RAW, fieldTypeAmountRaw);
> }
> {code}
> ...this code should probably be changed to use docValues by default -- or at the very least use the indexed/docValues options from the original (user configured) {{CurrencyField}} when creating the underlying poly-fields. (although in this case we'll want to be careful to ensure that if it's {{docValues=true}} we should only end up with 2 sets of docValues -- suffix_raw & suffix_currency -- and not 3, including the original)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org