Re: [PR] Fix bug with server return final aggregation result when null handling is enabled [pinot]

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #14181:
URL: https://github.com/apache/pinot/pull/14181#discussion_r1792527885


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/results/AggregationResultsBlock.java:
##########
@@ -116,7 +116,8 @@ public DataTable getDataTable()
       }
       dataTableBuilder.startRow();
       for (int i = 0; i < numColumns; i++) {
-        Object result = _results.get(i);
+        Object result =
+            returnFinalResult ? _aggregationFunctions[i].extractFinalResult(_results.get(i)) : _results.get(i);

Review Comment:
   Does this mean we need to handle `null` in all `extractFinalResult()`? Should we first check null, then convert the result?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org