You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/01 08:39:43 UTC
[GitHub] [incubator-seatunnel] CalvinKirs opened a new pull request #1361: [Deploy][Tools]Add release plugin
CalvinKirs opened a new pull request #1361:
URL: https://github.com/apache/incubator-seatunnel/pull/1361
Delete meaningless maven plugins and use release plugins for management
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1361: [Build][Tools]Add release plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1361:
URL: https://github.com/apache/incubator-seatunnel/pull/1361#discussion_r816613855
##########
File path: pom.xml
##########
@@ -851,6 +794,26 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <encoding>UTF-8</encoding>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-release-plugin</artifactId>
+ <version>${maven-release-plugin.version}</version>
Review comment:
thanks, we don't need to declare the version anymore, I will delete the version field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1361: [Build][Tools]Add release plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1361:
URL: https://github.com/apache/incubator-seatunnel/pull/1361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on a change in pull request #1361: [Build][Tools]Add release plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1361:
URL: https://github.com/apache/incubator-seatunnel/pull/1361#discussion_r816569098
##########
File path: pom.xml
##########
@@ -851,6 +794,26 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <encoding>UTF-8</encoding>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-release-plugin</artifactId>
+ <version>${maven-release-plugin.version}</version>
Review comment:
The version of this plugin is managed by the parent POM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org