[GitHub] underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional leading slash in CLI commands

[gi...@git.apache.org]

underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional leading slash in CLI commands
URL: https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131702597
 
 

 ##########
 File path: tools/cli/go-whisk-cli/commands/util.go
 ##########
 @@ -41,13 +41,7 @@ import (
     "bytes"
 )
 
-type QualifiedName struct {
-    namespace   string  // namespace. does not include leading '/'.  may be "" (i.e. default namespace)
-    packageName string  // package.  may be "".  does not include leading/trailing '/'
-    entity      string  // entity.  should not be ""
-    entityName  string  // pkg+entity
-}
-
+// TODO: DELETE THIS BLOCK OF CODE ONCE API-EXPERIMENTAL IS REMOVED!!!!!********
 
 Review comment:
   Sorry - I wasn't sure about the timeline for api-experimental being removed, and so I was trying to be proactive in case there was some chance this might get merged before that specific change. I reverted all api-experimental code back to the way it was before I made changes to it, and a added this code back in so that tests would still run properly in playground/travis. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services