[GitHub] [beam] mosche commented on a diff in pull request #24837: Enable async processing for SDF on Spark runner #23852

[GitBox <gi...@apache.org>]

mosche commented on code in PR #24837:
URL: https://github.com/apache/beam/pull/24837#discussion_r1060655719


##########
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkCommonPipelineOptions.java:
##########
@@ -84,4 +84,11 @@ static void prepareFilesToStage(SparkCommonPipelineOptions options) {
       PipelineResources.prepareFilesForStaging(options);
     }
   }
+
+  @Description(
+      "Enable/disable async output for operators with possibly large output ( such as splittable DoFn )")
+  @Default.Boolean(true)
+  Boolean getEnableAsyncOperatorOutput();

Review Comment:
   How about using [ExperimentalOptions](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/options/ExperimentalOptions.java#L50-L57) to opt-in initially? Removing a pipeline option again is always a hassle as it obviously is a breaking change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org