You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/08/29 21:40:17 UTC
[GitHub] [storm] kishorvpatil commented on a change in pull request #3121:
STORM-3479 HB timeout configurable on a topology level
kishorvpatil commented on a change in pull request #3121: STORM-3479 HB timeout configurable on a topology level
URL: https://github.com/apache/storm/pull/3121#discussion_r319283424
##########
File path: storm-server/src/main/java/org/apache/storm/DaemonConfig.java
##########
@@ -800,6 +800,16 @@
@NotNull
public static final String SUPERVISOR_WORKER_START_TIMEOUT_SECS = "supervisor.worker.start.timeout.secs";
+ /**
+ * Maximum allowed time for how long a worker can go without heartbeating before the supervisor tries to restart the worker process.
+ * Upper limit for Config.TOPOLOGY_WORKER_TIMEOUT_SECS.
+ *
+ */
+ @IsInteger
+ @IsPositiveNumber
+ @NotNull
+ public static final String MAXIMUM_SUPERVISOR_WORKER_TIMEOUT_SECS = "supervisor.maximum.worker.timeout.secs";
Review comment:
the variable name needs have same order or words just capitalized and _ as separator. So the va name would be SUPERVISOR_MAXIMUM_WORKER_TIMEOUT_SECS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services