You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/12/01 00:55:24 UTC

Re: Review Request 53939: Added implementation for containerizer 'attach()' call.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53939/
-----------------------------------------------------------

(Updated Dec. 1, 2016, 12:55 a.m.)


Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Changes
-------

Rebased with previous patches.


Bugs: MESOS-6467
    https://issues.apache.org/jira/browse/MESOS-6467


Repository: mesos


Description
-------

Added implementation for containerizer 'attach()' call.


Diffs (updated)
-----

  src/slave/containerizer/composing.cpp e0818bce8a8c3561f2fdd1127cea9ce310ae7f4d 
  src/slave/containerizer/mesos/containerizer.cpp 7dde6fc7c20ecd3543891e7d33230d0eaf9460a2 
  src/slave/containerizer/mesos/io/switchboard.hpp d3ab52d98ade067ccec63f3539073c152840099f 
  src/slave/containerizer/mesos/io/switchboard.cpp ae7a1fe3e24d5dc18269d9da951493700ee957d0 

Diff: https://reviews.apache.org/r/53939/diff/


Testing
-------

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues


Re: Review Request 53939: Added implementation for containerizer 'attach()' call.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53939/
-----------------------------------------------------------

(Updated Dec. 3, 2016, 8:03 p.m.)


Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Changes
-------

Updated the JIRA link


Bugs: MESOS-6546
    https://issues.apache.org/jira/browse/MESOS-6546


Repository: mesos


Description
-------

Added implementation for containerizer 'attach()' call.


Diffs
-----

  src/slave/containerizer/composing.cpp e0818bce8a8c3561f2fdd1127cea9ce310ae7f4d 
  src/slave/containerizer/mesos/containerizer.cpp 7dde6fc7c20ecd3543891e7d33230d0eaf9460a2 
  src/slave/containerizer/mesos/io/switchboard.hpp d3ab52d98ade067ccec63f3539073c152840099f 
  src/slave/containerizer/mesos/io/switchboard.cpp ae7a1fe3e24d5dc18269d9da951493700ee957d0 

Diff: https://reviews.apache.org/r/53939/diff/


Testing
-------

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues


Re: Review Request 53939: Added implementation for containerizer 'attach()' call.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53939/
-----------------------------------------------------------

(Updated Dec. 1, 2016, 1:45 a.m.)


Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Changes
-------

Updated based on Jie's comments.


Bugs: MESOS-6467
    https://issues.apache.org/jira/browse/MESOS-6467


Repository: mesos


Description
-------

Added implementation for containerizer 'attach()' call.


Diffs (updated)
-----

  src/slave/containerizer/composing.cpp e0818bce8a8c3561f2fdd1127cea9ce310ae7f4d 
  src/slave/containerizer/mesos/containerizer.cpp 7dde6fc7c20ecd3543891e7d33230d0eaf9460a2 
  src/slave/containerizer/mesos/io/switchboard.hpp d3ab52d98ade067ccec63f3539073c152840099f 
  src/slave/containerizer/mesos/io/switchboard.cpp ae7a1fe3e24d5dc18269d9da951493700ee957d0 

Diff: https://reviews.apache.org/r/53939/diff/


Testing
-------

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues