You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yanboliang <gi...@git.apache.org> on 2015/11/11 10:42:31 UTC
[GitHub] spark pull request: [SPARK-11651] [ML] LinearRegressionSummary sho...
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/9626
[SPARK-11651] [ML] LinearRegressionSummary should support get residuals by type
LinearRegressionSummary should support get residuals by type.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanboliang/spark spark-11651
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9626.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9626
----
commit 90d2d7aaea54ecd6c5eee0f8df125ba976682964
Author: Yanbo Liang <yb...@gmail.com>
Date: 2015-11-11T09:39:13Z
LinearRegressionSummary should support get residuals by type
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11651] [ML] LinearRegressionSummary sho...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9626#issuecomment-163647383
**[Test build #47510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47510/consoleFull)** for PR 9626 at commit [`90d2d7a`](https://github.com/apache/spark/commit/90d2d7aaea54ecd6c5eee0f8df125ba976682964).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11651] [ML] LinearRegressionSummary sho...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9626#issuecomment-155730501
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45625/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11651] [ML] LinearRegressionSummary sho...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9626#issuecomment-155730382
**[Test build #45625 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45625/consoleFull)** for PR 9626 at commit [`90d2d7a`](https://github.com/apache/spark/commit/90d2d7aaea54ecd6c5eee0f8df125ba976682964).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:\n * `sealed abstract class State[S] `\n * `sealed abstract class StateSpec[KeyType, ValueType, StateType, EmittedType] extends Serializable `\n * `case class StateSpecImpl[K, V, S, T](`\n * `sealed abstract class TrackStateDStream[KeyType, ValueType, StateType, EmittedType: ClassTag](`\n * `class InternalTrackStateDStream[K: ClassTag, V: ClassTag, S: ClassTag, E: ClassTag](`\n * ` case class StateInfo[S](`\n * ` class LimitMarker(val num: Int) extends Serializable`\n
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11651] [ML] LinearRegressionSummary sho...
Posted by yanboliang <gi...@git.apache.org>.
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9626#discussion_r44518353
--- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -522,18 +522,40 @@ class LinearRegressionSummary private[regression] (
}
/**
+ * Return the residuals by type.
+ * Supported options: "deviance", "pearson", "working" and "response".
+ * Default is "deviance".
+ */
+ def residualsByType(residualsType: String = "deviance"): DataFrame = {
--- End diff --
I have not figured out a better name, ```residuals``` has been occupied. Or should we remove or deprecate ```residuals``? @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11651] [ML] LinearRegressionSummary sho...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9626#issuecomment-155718700
**[Test build #45625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45625/consoleFull)** for PR 9626 at commit [`90d2d7a`](https://github.com/apache/spark/commit/90d2d7aaea54ecd6c5eee0f8df125ba976682964).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11651] [ML] LinearRegressionSummary sho...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9626#issuecomment-155730500
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11651] [ML] LinearRegressionSummary sho...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9626#issuecomment-155718026
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11651] [ML] LinearRegressionSummary sho...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9626#issuecomment-155718044
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11651] [ML] LinearRegressionSummary sho...
Posted by yanboliang <gi...@git.apache.org>.
Github user yanboliang closed the pull request at:
https://github.com/apache/spark/pull/9626
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org