You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/09/23 05:53:31 UTC
Review Request 38622: Ranger UI - KMS Need to handle 404 error when
clicked on breadcrumb
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38622/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-656
https://issues.apache.org/jira/browse/RANGER-656
Repository: ranger
Description
-------
Taken care of breadcrumbs which was earlier giving 404 as it was trying to pass model.id for 'Create repo' link. Added void(0) so that it doesn't look for any model.
Diffs
-----
security-admin/src/bin/ranger_install.py 99c8ab8
security-admin/src/main/webapp/scripts/modules/XALinks.js efa3454
security-admin/src/main/webapp/scripts/views/kms/KmsKeyCreate.js 1ee0b3d
security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 239b61e
Diff: https://reviews.apache.org/r/38622/diff/
Testing
-------
Tested on local setup of Ranger for broken links.
Thanks,
Gautam Borad
Re: Review Request 38622: RANGER-656 : Ranger UI - KMS Need to handle
404 error when clicked on breadcrumb
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38622/#review100787
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Sept. 25, 2015, 5:36 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38622/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 5:36 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-656
> https://issues.apache.org/jira/browse/RANGER-656
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Taken care of breadcrumbs which was earlier giving 404 as it was trying to pass model.id for 'Create repo' link. Added void(0) so that it doesn't look for any model.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/XALinks.js efa3454
> security-admin/src/main/webapp/scripts/views/kms/KmsKeyCreate.js 1ee0b3d
> security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 239b61e
>
> Diff: https://reviews.apache.org/r/38622/diff/
>
>
> Testing
> -------
>
> Tested on local setup of Ranger for broken links.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38622: RANGER-656 : Ranger UI - KMS Need to handle
404 error when clicked on breadcrumb
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38622/
-----------------------------------------------------------
(Updated Sept. 25, 2015, 5:36 a.m.)
Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Updated the patch and moved property name change to another JIRA.
Summary (updated)
-----------------
RANGER-656 : Ranger UI - KMS Need to handle 404 error when clicked on breadcrumb
Bugs: RANGER-656
https://issues.apache.org/jira/browse/RANGER-656
Repository: ranger
Description
-------
Taken care of breadcrumbs which was earlier giving 404 as it was trying to pass model.id for 'Create repo' link. Added void(0) so that it doesn't look for any model.
Diffs (updated)
-----
security-admin/src/main/webapp/scripts/modules/XALinks.js efa3454
security-admin/src/main/webapp/scripts/views/kms/KmsKeyCreate.js 1ee0b3d
security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 239b61e
Diff: https://reviews.apache.org/r/38622/diff/
Testing
-------
Tested on local setup of Ranger for broken links.
Thanks,
Gautam Borad