[GitHub] [arrow] westonpace commented on a change in pull request #9975: ARROW-12325: [C++] [CI] Nightly gandiva build failing due to failure of compiler to move return value

[GitBox <gi...@apache.org>]

westonpace commented on a change in pull request #9975:
URL: https://github.com/apache/arrow/pull/9975#discussion_r614749123



##########
File path: cpp/src/arrow/util/vector.h
##########
@@ -130,7 +130,7 @@ Result<std::vector<T>> UnwrapOrRaise(std::vector<Result<T>>&& results) {
     }
     out.push_back(it->MoveValueUnsafe());
   }
-  return out;
+  return std::move(out);

Review comment:
       I agree, it's harmless and not actively used, so this one instance is not really something to worry over much about.  Thinking on it more I think I was more surprised we get away with it everywhere else.  We are returning `Result` most of the time and we don't usually move return values.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org