You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/03 09:58:07 UTC

[GitHub] [spark] wzhfy opened a new pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

wzhfy opened a new pull request #29636:
URL: https://github.com/apache/spark/pull/29636


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   The whole `DynamicPartitionPruningSuite` takes about 2 min in my laptop (either AE on or off). The slowest tests are `test("simple inner join triggers DPP with mock-up tables")` and `test("cleanup any DPP filter that isn't pushed down due to expression id clashes")`, which totally takes about 1 min.
   
   We can reuse existing test tables or use smaller tables to reduce the cost. After that, the two tests takes only about 1 sec in total, leading to 2x speedup for the suite.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   To speedup DPP test suites.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Modified two existing tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wzhfy commented on a change in pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

Posted by GitBox <gi...@apache.org>.
wzhfy commented on a change in pull request #29636:
URL: https://github.com/apache/spark/pull/29636#discussion_r482862098



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -1157,7 +1143,7 @@ abstract class DynamicPartitionPruningSuiteBase
   test("cleanup any DPP filter that isn't pushed down due to expression id clashes") {
     withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_REUSE_BROADCAST_ONLY.key -> "true") {
       withTable("fact", "dim") {
-        spark.range(1000).select($"id".as("A"), $"id".as("AA"))
+        spark.range(20).select($"id".as("A"), $"id".as("AA"))

Review comment:
       We don't have two reasonable join keys between available tables, so I just reduce the number of records (partitions) here. It's unnecessary to create so many partitions in this test.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686387564






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wzhfy commented on a change in pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

Posted by GitBox <gi...@apache.org>.
wzhfy commented on a change in pull request #29636:
URL: https://github.com/apache/spark/pull/29636#discussion_r482862098



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -1157,7 +1143,7 @@ abstract class DynamicPartitionPruningSuiteBase
   test("cleanup any DPP filter that isn't pushed down due to expression id clashes") {
     withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_REUSE_BROADCAST_ONLY.key -> "true") {
       withTable("fact", "dim") {
-        spark.range(1000).select($"id".as("A"), $"id".as("AA"))
+        spark.range(20).select($"id".as("A"), $"id".as("AA"))

Review comment:
       We don't have two reasonable join keys between available tables, so I just reduce the records (number of partitions) here. It's unnecessary to create so many partitions in this test.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686386669


   **[Test build #128250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128250/testReport)** for PR 29636 at commit [`c49376a`](https://github.com/apache/spark/commit/c49376a921e2d3aa1c412feb62cc40cb6b5d760c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wzhfy commented on pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

Posted by GitBox <gi...@apache.org>.
wzhfy commented on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686513240


   also cc @cloud-fan @wangyum 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686386669


   **[Test build #128250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128250/testReport)** for PR 29636 at commit [`c49376a`](https://github.com/apache/spark/commit/c49376a921e2d3aa1c412feb62cc40cb6b5d760c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu closed pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

Posted by GitBox <gi...@apache.org>.
maropu closed pull request #29636:
URL: https://github.com/apache/spark/pull/29636


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686832660


   Thanks! Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686535677


   **[Test build #128250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128250/testReport)** for PR 29636 at commit [`c49376a`](https://github.com/apache/spark/commit/c49376a921e2d3aa1c412feb62cc40cb6b5d760c).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686387564






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686537290






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu edited a comment on pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

Posted by GitBox <gi...@apache.org>.
maropu edited a comment on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686832660


   Thanks! Merged to master/branch-3.0.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29636: [SPARK-32786][SQL][TEST] Improve performance for some slow DPP tests

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686537290






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org