[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1436: nimble/ll: Some updates before ISO BIG

["apache-mynewt-bot (via GitHub)" <gi...@apache.org>]

apache-mynewt-bot commented on PR #1436:
URL: https://github.com/apache/mynewt-nimble/pull/1436#issuecomment-1406615296

   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### nimble/controller/src/ble_ll_adv.c
   <details>
   
   ```diff
   @@ -2770,7 +2769,7 @@
        advsm->event_cntr = 0;
        access_addr = ble_ll_utils_calc_aa();
        advsm->channel_id = ((access_addr & 0xffff0000) >> 16) ^
   -                         (access_addr & 0x0000ffff);
   +                        (access_addr & 0x0000ffff);
    #endif
    
        /* Set first advertising channel */
   ```
   
   </details>
   
   #### nimble/controller/src/ble_ll_conn.c
   <details>
   
   ```diff
   @@ -1269,8 +1268,8 @@
    #endif
    
            ticks = (BLE_LL_IFS * 3) + connsm->ota_max_rx_time +
   -            ble_ll_pdu_us(next_txlen, tx_phy_mode) +
   -            ble_ll_pdu_us(cur_txlen, tx_phy_mode);
   +                ble_ll_pdu_us(next_txlen, tx_phy_mode) +
   +                ble_ll_pdu_us(cur_txlen, tx_phy_mode);
    
    #if MYNEWT_VAL(BLE_LL_ROLE_CENTRAL)
            if (connsm->conn_role == BLE_LL_CONN_ROLE_CENTRAL) {
   @@ -3690,7 +3689,7 @@
        rx_phy_mode = BLE_PHY_MODE_1M;
    #endif
        add_usecs = rxhdr->rem_usecs +
   -            ble_ll_pdu_us(rx_pyld_len, rx_phy_mode);
   +                ble_ll_pdu_us(rx_pyld_len, rx_phy_mode);
    
        /*
         * Check the packet CRC. A connection event can continue even if the
   @@ -4342,10 +4341,10 @@
    #endif
    
    #define MAX_TIME_UNCODED(_maxbytes) \
   -        ble_ll_pdu_us(_maxbytes + BLE_LL_DATA_MIC_LEN, \
   +    ble_ll_pdu_us(_maxbytes + BLE_LL_DATA_MIC_LEN, \
                                   BLE_PHY_MODE_1M);
    #define MAX_TIME_CODED(_maxbytes) \
   -        ble_ll_pdu_us(_maxbytes + BLE_LL_DATA_MIC_LEN, \
   +    ble_ll_pdu_us(_maxbytes + BLE_LL_DATA_MIC_LEN, \
                                   BLE_PHY_MODE_CODED_125KBPS);
    
    /**
   ```
   
   </details>
   
   #### nimble/include/nimble/hci_common.h
   <details>
   
   ```diff
   @@ -1829,17 +1829,17 @@
    
    #define BLE_HCI_LE_SUBEV_PERIODIC_ADV_SYNC_TRANSFER   (0x18)
    struct ble_hci_ev_le_subev_periodic_adv_sync_transfer {
   -    uint8_t  subev_code;
   -    uint8_t  status;
   +    uint8_t subev_code;
   +    uint8_t status;
        uint16_t conn_handle;
        uint16_t service_data;
        uint16_t sync_handle;
   -    uint8_t  sid;
   -    uint8_t  peer_addr_type;
   -    uint8_t  peer_addr[6];
   -    uint8_t  phy;
   +    uint8_t sid;
   +    uint8_t peer_addr_type;
   +    uint8_t peer_addr[6];
   +    uint8_t phy;
        uint16_t interval;
   -    uint8_t  aca;
   +    uint8_t aca;
    } __attribute__((packed));
    
    #define BLE_HCI_LE_SUBEV_CIS_ESTABLISHED        (0x19)
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org