You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@bifromq.apache.org by GitBox <gi...@apache.org> on 2026/10/25 18:01:46 UTC

[GH] (bifromq/fix/kv-server-restore-future): Workflow run "Build and Test BifroMQ" failed!

The GitHub Actions job "Build and Test BifroMQ" on bifromq.git/fix/kv-server-restore-future has failed.
Run started by GitHub user ImDanXie (triggered by ImDanXie).

Head commit for run:
a2e4c059b0e5739a639680053dd5813237a4954a / ImDanXie <wo...@gmail.com>
fix(kv-server): complete the restore session future on synchronous start failure

restoreFrom() swallows any Throwable from startRestore()/messenger.send() with
just a log line, leaving the session's doneFuture pending forever. There is no
timeout on this path, and because the session remains cached and un-done, a
retry with the same snapshot (same leader) hits the reuse branch and returns
the same dead future - the range is permanently stuck after a failed snapshot
install.

Complete the future exceptionally in the catch block, so callers observe the
failure and a retry starts a fresh session.

Control experiment: restoreFromStartFailureCompletesFutureExceptionally fails
on the old code and passes with the fix; existing restore expectations
unchanged (9/9).

Fixes #303

Report URL: https://github.com/apache/bifromq/actions/runs/36170779149

With regards,
GitHub Actions via GitBox