You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/08/08 08:11:26 UTC
[PR] feat(cpp): run C++ SDK tests only against the VSR server [iggy]
hubcio opened a new pull request, #3844:
URL: https://github.com/apache/iggy/pull/3844
The C++ bindings were the last SDK exercised only against the legacy
server. Moving the e2e and BDD lanes to a vsr-built iggy-server-ng
meant rewriting every legacy-only expectation: logout drops the
client-table entry, flush_unsaved_buffer denies typed, cluster
metadata is readable pre-login, group ids are minted monotonically,
and a send reports the written offsets.
Four gaps surfaced as bugs. Stats hardcoded clients_count to 0 because
the sync read path could not run the cross-shard ListClients gather. A
poll against a missing stream or topic answered the generic
InvalidIdentifier. An over-count partition delete acked a no-op
instead of InvalidPartitionsCount. A purge acked before its counters
moved, so an immediate read saw pre-purge totals; the reset now runs
in the apply, gated on the purge generation because left-right replays
it on the second buffer after the ack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(cpp): run C++ SDK tests only against the VSR server [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3844:
URL: https://github.com/apache/iggy/pull/3844#issuecomment-5225275531
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3844?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.15%. Comparing base ([`01a64b2`](https://app.codecov.io/gh/apache/iggy/commit/01a64b2e00eb3037d45a85e4cdefe09eed6e2e07?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e36e537`](https://app.codecov.io/gh/apache/iggy/commit/e36e53779ce920bac3823fef4b8326c08e767f60?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3844 +/- ##
============================================
- Coverage 76.58% 76.15% -0.43%
Complexity 1046 1046
============================================
Files 1347 1345 -2
Lines 171018 170704 -314
Branches 142372 142252 -120
============================================
- Hits 130967 130002 -965
- Misses 36233 36884 +651
Partials 3818 3818
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/3844/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3844/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.79% <ø> (+0.01%)` | :arrow_up: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3844/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.67% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3844/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.28% <ø> (ø)` | |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3844/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.70% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/3844/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.97% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3844/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.68% <ø> (-6.61%)` | :arrow_down: |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3844/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.18% <ø> (ø)` | |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/3844?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/metadata/src/stm/result.rs](https://app.codecov.io/gh/apache/iggy/pull/3844?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fresult.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL3Jlc3VsdC5ycw==) | `92.17% <ø> (ø)` | |
| [core/metadata/src/stm/stream.rs](https://app.codecov.io/gh/apache/iggy/pull/3844?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fstream.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL3N0cmVhbS5ycw==) | `74.62% <ø> (-0.15%)` | :arrow_down: |
| [core/server-ng/src/dispatch.rs](https://app.codecov.io/gh/apache/iggy/pull/3844?src=pr&el=tree&filepath=core%2Fserver-ng%2Fsrc%2Fdispatch.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXItbmcvc3JjL2Rpc3BhdGNoLnJz) | `40.51% <ø> (+0.01%)` | :arrow_up: |
| [core/server-ng/src/http/reads.rs](https://app.codecov.io/gh/apache/iggy/pull/3844?src=pr&el=tree&filepath=core%2Fserver-ng%2Fsrc%2Fhttp%2Freads.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXItbmcvc3JjL2h0dHAvcmVhZHMucnM=) | `17.14% <ø> (ø)` | |
| [core/server-ng/src/responses.rs](https://app.codecov.io/gh/apache/iggy/pull/3844?src=pr&el=tree&filepath=core%2Fserver-ng%2Fsrc%2Fresponses.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXItbmcvc3JjL3Jlc3BvbnNlcy5ycw==) | `41.65% <ø> (+0.33%)` | :arrow_up: |
| [core/simulator/src/workload/effect.rs](https://app.codecov.io/gh/apache/iggy/pull/3844?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Fworkload%2Feffect.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL3dvcmtsb2FkL2VmZmVjdC5ycw==) | `0.00% <ø> (ø)` | |
| [...re/simulator/src/workload/ops/create\_partitions.rs](https://app.codecov.io/gh/apache/iggy/pull/3844?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Fworkload%2Fops%2Fcreate_partitions.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL3dvcmtsb2FkL29wcy9jcmVhdGVfcGFydGl0aW9ucy5ycw==) | `20.51% <ø> (+1.00%)` | :arrow_up: |
| [...re/simulator/src/workload/ops/delete\_partitions.rs](https://app.codecov.io/gh/apache/iggy/pull/3844?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Fworkload%2Fops%2Fdelete_partitions.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL3dvcmtsb2FkL29wcy9kZWxldGVfcGFydGl0aW9ucy5ycw==) | `0.00% <ø> (ø)` | |
| [core/simulator/src/workload/shadow.rs](https://app.codecov.io/gh/apache/iggy/pull/3844?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Fworkload%2Fshadow.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL3dvcmtsb2FkL3NoYWRvdy5ycw==) | `37.56% <ø> (+1.24%)` | :arrow_up: |
... and [52 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3844/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(cpp): run C++ SDK tests only against the VSR server [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #3844:
URL: https://github.com/apache/iggy/pull/3844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org