You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/03/05 07:45:34 UTC

[GitHub] [lucene-solr] iverase opened a new pull request #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint

iverase opened a new pull request #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint
URL: https://github.com/apache/lucene-solr/pull/1318
 
 
   This PR removes the calculation from the planet model and move it to Geo3DUtil. Planet model is generic and it does not need and spheroid representing the earth.
   
   @nknize can you have a look? We should fix it before the 8.5 release? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] iverase commented on issue #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint

Posted by GitBox <gi...@apache.org>.
iverase commented on issue #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint
URL: https://github.com/apache/lucene-solr/pull/1318#issuecomment-596605527
 
 
   updated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] nknize commented on a change in pull request #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint

Posted by GitBox <gi...@apache.org>.
nknize commented on a change in pull request #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint
URL: https://github.com/apache/lucene-solr/pull/1318#discussion_r389458480
 
 

 ##########
 File path: lucene/spatial3d/src/test/org/apache/lucene/spatial3d/TestGeo3DPoint.java
 ##########
 @@ -1328,6 +1329,32 @@ public void testEncodeDecodeIsStable() throws Exception {
     }
   }
 
+  public void testDistanceQuery() throws Exception {
+    Directory dir = newDirectory();
+    RandomIndexWriter w = new RandomIndexWriter(random(), dir);
+
+    PlanetModel planetModel = PlanetModel.WGS84;
 
 Review comment:
   Can we test this with the PlanetModel randomly selected from all three (Clarke, Sphere, WGS84)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] iverase commented on a change in pull request #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint

Posted by GitBox <gi...@apache.org>.
iverase commented on a change in pull request #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint
URL: https://github.com/apache/lucene-solr/pull/1318#discussion_r389499050
 
 

 ##########
 File path: lucene/spatial3d/src/test/org/apache/lucene/spatial3d/TestGeo3DPoint.java
 ##########
 @@ -1328,6 +1329,32 @@ public void testEncodeDecodeIsStable() throws Exception {
     }
   }
 
+  public void testDistanceQuery() throws Exception {
+    Directory dir = newDirectory();
+    RandomIndexWriter w = new RandomIndexWriter(random(), dir);
+
+    PlanetModel planetModel = PlanetModel.WGS84;
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] iverase merged pull request #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint

Posted by GitBox <gi...@apache.org>.
iverase merged pull request #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint
URL: https://github.com/apache/lucene-solr/pull/1318
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] iverase commented on issue #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint

Posted by GitBox <gi...@apache.org>.
iverase commented on issue #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint
URL: https://github.com/apache/lucene-solr/pull/1318#issuecomment-596374766
 
 
   One thing that worries me is that we built Planet models using minor and major axis but equality of a planet model is done through xyScaling and zScaling, is that an issue for you?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] iverase commented on issue #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint

Posted by GitBox <gi...@apache.org>.
iverase commented on issue #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint
URL: https://github.com/apache/lucene-solr/pull/1318#issuecomment-596068243
 
 
   @nknize, I had another iteration and decided to go back to one constructor that defines the semiMajorAxis and semiMinorAxis only (The fattening factor was not used and can be calculated anyway from those two values).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] nknize commented on issue #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint

Posted by GitBox <gi...@apache.org>.
nknize commented on issue #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint
URL: https://github.com/apache/lucene-solr/pull/1318#issuecomment-596598868
 
 
   @iverase good point. With these changes the `equals` and `hashCode` methods should also be changed to use major and minor axis

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org