[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #646: MINIFICPP-1031 - RemoteProcessorGroupPort::setURL fails in case port …

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #646: MINIFICPP-1031 - RemoteProcessorGroupPort::setURL fails in case port …
URL: https://github.com/apache/nifi-minifi-cpp/pull/646#discussion_r325195183
 
 

 ##########
 File path: libminifi/include/RemoteProcessorGroupPort.h
 ##########
 @@ -146,7 +146,7 @@ class RemoteProcessorGroupPort : public core::Processor {
     for (auto url : urls) {
       logger_->log_trace("Parsing %s", url);
       std::string host, protocol;
-      int port;
+      int port = -1;
 
 Review comment:
   In case the protocol is nor http neither https (but it's specified) parse_util fails, both host and protocol remains empty. 
   Not nice, I would also prefer an exception to be thrown, but that would break this API, so I didn't change it. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services