[jira] [Commented] (CB-9070) Incorrect Documentation/Implementation for camera.getPicture() and CameraPopoverHandle

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-9070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401218#comment-15401218 ] 

ASF GitHub Bot commented on CB-9070:
------------------------------------

GitHub user jcesarmobile opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/225

    CB-9070. (ios) Fixed CameraPopoverHandle documentation

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Fix the documentation about the CameraPopoverHandle
    
    ### What testing has been done on this change?
    Tested that the new doc is displayed correctly
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcesarmobile/cordova-plugin-camera CB-9070

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/225.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #225
    
----
commit 943504c7e2e4b7ee9f3d0819ca3f3d11b9ae3986
Author: Julio César <jc...@gmail.com>
Date:   2016-07-31T16:06:39Z

    CB-9070. (ios) Fixed CameraPopoverHandle documentation

----


> Incorrect Documentation/Implementation for camera.getPicture() and CameraPopoverHandle
> --------------------------------------------------------------------------------------
>
>                 Key: CB-9070
>                 URL: https://issues.apache.org/jira/browse/CB-9070
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>    Affects Versions: 5.0.0
>         Environment: iOS
>            Reporter: Eric Butler
>            Assignee: jcesarmobile
>            Priority: Minor
>              Labels: ios
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The documentation in the readme states that getPicture() returns a CameraPopoverHandle that allows the developer to position and handle the prompt or filehandling ui pieces. However that return has been commented out since Dec 2013. 
> Should this be uncommented or should the doc be updated to reflect that?
> Compare -
> docs: http://i.imgur.com/Ous71H5.png 
> actual: http://tinyurl.com/lf38bpr 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org