You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Arne Baganz (JIRA)" <ji...@apache.org> on 2012/05/09 18:05:48 UTC
[jira] [Created] (WICKET-4546) Unencoded ampersands in
CSS-/Javascript-Reference
Arne Baganz created WICKET-4546:
-----------------------------------
Summary: Unencoded ampersands in CSS-/Javascript-Reference
Key: WICKET-4546
URL: https://issues.apache.org/jira/browse/WICKET-4546
Project: Wicket
Issue Type: Bug
Affects Versions: 1.5.6
Reporter: Arne Baganz
Ampersands in CSS-/Javascript-References are not encoded properly, see the source code (html) in:
http://www.wicket-library.com/wicket-examples/resourceaggregation
{quote}
<!-- BasicGroupingKey [group=GLOBAL, loadOrder=0, css=true] -->
<link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:footer.css%7Corg.apache.wicket.examples.resourcedecoration.HomePage:header.css&type=css" />
<!-- BasicGroupingKey [group=APPLICATION, loadOrder=0, css=true] -->
<link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:app.css&type=css" />
<!-- BasicGroupingKey [group=PAGE, loadOrder=0, css=true] -->
<link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:HomePage.css&type=css" />{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4546) Unencoded ampersands in
CSS-/Javascript-Reference
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272394#comment-13272394 ]
Martin Grigorov commented on WICKET-4546:
-----------------------------------------
Which ampersand exactly do you mean ?
> Unencoded ampersands in CSS-/Javascript-Reference
> -------------------------------------------------
>
> Key: WICKET-4546
> URL: https://issues.apache.org/jira/browse/WICKET-4546
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5.6
> Reporter: Arne Baganz
> Labels: ampersand, css, encoding, javascript, url
>
> Ampersands in CSS-/Javascript-References are not encoded properly, see the source code (html) in:
> http://www.wicket-library.com/wicket-examples/resourceaggregation
> {quote}
> <!-- BasicGroupingKey [group=GLOBAL, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:footer.css%7Corg.apache.wicket.examples.resourcedecoration.HomePage:header.css&type=css" />
> <!-- BasicGroupingKey [group=APPLICATION, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:app.css&type=css" />
> <!-- BasicGroupingKey [group=PAGE, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:HomePage.css&type=css" />{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4546) Unencoded ampersands in
CSS-/Javascript-Reference
Posted by "Arne Baganz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272398#comment-13272398 ]
Arne Baganz commented on WICKET-4546:
-------------------------------------
The ampersand before &type, i.e. &type=css or custom parameters if I add any.
> Unencoded ampersands in CSS-/Javascript-Reference
> -------------------------------------------------
>
> Key: WICKET-4546
> URL: https://issues.apache.org/jira/browse/WICKET-4546
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5.6
> Reporter: Arne Baganz
> Labels: ampersand, css, encoding, javascript, url
>
> Ampersands in CSS-/Javascript-References are not encoded properly, see the source code (html) in:
> http://www.wicket-library.com/wicket-examples/resourceaggregation
> {quote}
> <!-- BasicGroupingKey [group=GLOBAL, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:footer.css%7Corg.apache.wicket.examples.resourcedecoration.HomePage:header.css&type=css" />
> <!-- BasicGroupingKey [group=APPLICATION, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:app.css&type=css" />
> <!-- BasicGroupingKey [group=PAGE, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:HomePage.css&type=css" />{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4546) Unencoded ampersands in
CSS-/Javascript-Reference
Posted by "Arne Baganz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272390#comment-13272390 ]
Arne Baganz commented on WICKET-4546:
-------------------------------------
I did not mean the pipe ( | ) symbol but the ampersand ( & ).
See: http://www.htmlhelp.com/tools/validator/problems.html#amp
So according to the W3C it is a problem.
Ampersand encoding in wicket has quite a ticket history, just to name a few:
WICKET-358 WICKET-559 WICKET-2131 WICKET-3334
> Unencoded ampersands in CSS-/Javascript-Reference
> -------------------------------------------------
>
> Key: WICKET-4546
> URL: https://issues.apache.org/jira/browse/WICKET-4546
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5.6
> Reporter: Arne Baganz
> Labels: ampersand, css, encoding, javascript, url
>
> Ampersands in CSS-/Javascript-References are not encoded properly, see the source code (html) in:
> http://www.wicket-library.com/wicket-examples/resourceaggregation
> {quote}
> <!-- BasicGroupingKey [group=GLOBAL, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:footer.css%7Corg.apache.wicket.examples.resourcedecoration.HomePage:header.css&type=css" />
> <!-- BasicGroupingKey [group=APPLICATION, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:app.css&type=css" />
> <!-- BasicGroupingKey [group=PAGE, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:HomePage.css&type=css" />{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4546) Unencoded ampersands in
CSS-/Javascript-Reference
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4546.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5.7
6.0.0-RC1
Assignee: Martin Grigorov
Improved! Thanks!
Wicket is even more famous now! :-)
> Unencoded ampersands in CSS-/Javascript-Reference
> -------------------------------------------------
>
> Key: WICKET-4546
> URL: https://issues.apache.org/jira/browse/WICKET-4546
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5.6
> Reporter: Arne Baganz
> Assignee: Martin Grigorov
> Labels: ampersand, css, encoding, javascript, url
> Fix For: 6.0.0-RC1, 1.5.7
>
>
> Ampersands in CSS-/Javascript-References are not encoded properly, see the source code (html) in:
> http://www.wicket-library.com/wicket-examples/resourceaggregation
> {quote}
> <!-- BasicGroupingKey [group=GLOBAL, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:footer.css%7Corg.apache.wicket.examples.resourcedecoration.HomePage:header.css&type=css" />
> <!-- BasicGroupingKey [group=APPLICATION, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:app.css&type=css" />
> <!-- BasicGroupingKey [group=PAGE, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:HomePage.css&type=css" />{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4546) Unencoded ampersands in
CSS-/Javascript-Reference
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272397#comment-13272397 ]
Martin Grigorov commented on WICKET-4546:
-----------------------------------------
The ampersands in the urls are normal delimiters for the request parameters, no ?
> Unencoded ampersands in CSS-/Javascript-Reference
> -------------------------------------------------
>
> Key: WICKET-4546
> URL: https://issues.apache.org/jira/browse/WICKET-4546
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5.6
> Reporter: Arne Baganz
> Labels: ampersand, css, encoding, javascript, url
>
> Ampersands in CSS-/Javascript-References are not encoded properly, see the source code (html) in:
> http://www.wicket-library.com/wicket-examples/resourceaggregation
> {quote}
> <!-- BasicGroupingKey [group=GLOBAL, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:footer.css%7Corg.apache.wicket.examples.resourcedecoration.HomePage:header.css&type=css" />
> <!-- BasicGroupingKey [group=APPLICATION, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:app.css&type=css" />
> <!-- BasicGroupingKey [group=PAGE, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:HomePage.css&type=css" />{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4546) Unencoded ampersands in
CSS-/Javascript-Reference
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4546.
-------------------------------------
Resolution: Not A Problem
This is how org.apache.wicket.examples.resourcedecoration.MergedResourcesResource works.
It puts '|' in the query parameter value and then splits on it.
> Unencoded ampersands in CSS-/Javascript-Reference
> -------------------------------------------------
>
> Key: WICKET-4546
> URL: https://issues.apache.org/jira/browse/WICKET-4546
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5.6
> Reporter: Arne Baganz
> Labels: ampersand, css, encoding, javascript, url
>
> Ampersands in CSS-/Javascript-References are not encoded properly, see the source code (html) in:
> http://www.wicket-library.com/wicket-examples/resourceaggregation
> {quote}
> <!-- BasicGroupingKey [group=GLOBAL, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:footer.css%7Corg.apache.wicket.examples.resourcedecoration.HomePage:header.css&type=css" />
> <!-- BasicGroupingKey [group=APPLICATION, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:app.css&type=css" />
> <!-- BasicGroupingKey [group=PAGE, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:HomePage.css&type=css" />{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (WICKET-4546) Unencoded ampersands in
CSS-/Javascript-Reference
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reopened WICKET-4546:
-------------------------------------
You are correct.
> Unencoded ampersands in CSS-/Javascript-Reference
> -------------------------------------------------
>
> Key: WICKET-4546
> URL: https://issues.apache.org/jira/browse/WICKET-4546
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5.6
> Reporter: Arne Baganz
> Labels: ampersand, css, encoding, javascript, url
>
> Ampersands in CSS-/Javascript-References are not encoded properly, see the source code (html) in:
> http://www.wicket-library.com/wicket-examples/resourceaggregation
> {quote}
> <!-- BasicGroupingKey [group=GLOBAL, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:footer.css%7Corg.apache.wicket.examples.resourcedecoration.HomePage:header.css&type=css" />
> <!-- BasicGroupingKey [group=APPLICATION, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:app.css&type=css" />
> <!-- BasicGroupingKey [group=PAGE, loadOrder=0, css=true] -->
> <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:HomePage.css&type=css" />{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira