[GitHub] [pulsar] eolivelli commented on a change in pull request #11012: PIP-45: Migrate OwnershipCache to use MetadataStore

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #11012:
URL: https://github.com/apache/pulsar/pull/11012#discussion_r656086151



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##########
@@ -631,168 +631,146 @@ protected void handleProducerRemoved(Producer producer) {
                                                  Map<String, String> metadata, boolean readCompacted,
                                                  InitialPosition initialPosition,
                                                  long startMessageRollbackDurationSec,
-                                                 boolean replicatedSubscriptionState,
+                                                 boolean replicatedSubscriptionStateArg,
                                                  KeySharedMeta keySharedMeta) {
+        return brokerService.checkTopicNsOwnership(getName()).thenCompose(__ -> {
+            if (readCompacted && !(subType == SubType.Failover || subType == SubType.Exclusive)) {

Review comment:
       we could move this validation outside of the `checkTopicNsOwnership` block.
   not a big deal, it is something that does not happen in the happy path




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org