You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by kw...@apache.org on 2014/12/29 11:28:03 UTC

svn commit: r1648303 - in /qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb: BDBHAReplicaVirtualHost.java BDBHAReplicaVirtualHostImpl.java

Author: kwall
Date: Mon Dec 29 10:28:02 2014
New Revision: 1648303

URL: http://svn.apache.org/r1648303
Log:
QPID-6289: [Java Broker] Fix for failing BDB system test caused by rev 1648039

* Introduced single root interface BDBHAReplicaVirtualHost to meet the requirements of the model

Added:
    qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHostImpl.java
      - copied, changed from r1648296, qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHost.java
Modified:
    qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHost.java

Modified: qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHost.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHost.java?rev=1648303&r1=1648302&r2=1648303&view=diff
==============================================================================
--- qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHost.java (original)
+++ qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHost.java Mon Dec 29 10:28:02 2014
@@ -19,458 +19,17 @@
 
 package org.apache.qpid.server.virtualhost.berkeleydb;
 
-import java.util.Collection;
-import java.util.Collections;
-import java.util.Map;
-import java.util.Set;
-import java.util.UUID;
-import java.util.concurrent.ScheduledFuture;
-
-import org.apache.qpid.server.connection.IConnectionRegistry;
 import org.apache.qpid.server.exchange.ExchangeImpl;
-import org.apache.qpid.server.logging.EventLogger;
-import org.apache.qpid.server.message.MessageDestination;
-import org.apache.qpid.server.message.MessageSource;
-import org.apache.qpid.server.model.AbstractConfiguredObject;
-import org.apache.qpid.server.model.BrokerModel;
-import org.apache.qpid.server.model.ConfiguredObject;
-import org.apache.qpid.server.model.Connection;
-import org.apache.qpid.server.model.Exchange;
-import org.apache.qpid.server.model.ManagedAttributeField;
-import org.apache.qpid.server.model.ManagedObject;
-import org.apache.qpid.server.model.ManagedObjectFactoryConstructor;
-import org.apache.qpid.server.model.Queue;
-import org.apache.qpid.server.model.State;
-import org.apache.qpid.server.model.VirtualHost;
-import org.apache.qpid.server.model.VirtualHostAlias;
-import org.apache.qpid.server.model.VirtualHostNode;
-import org.apache.qpid.server.protocol.LinkRegistry;
 import org.apache.qpid.server.queue.AMQQueue;
-import org.apache.qpid.server.stats.StatisticsCounter;
-import org.apache.qpid.server.store.DurableConfigurationStore;
-import org.apache.qpid.server.store.MessageStore;
-import org.apache.qpid.server.txn.DtxRegistry;
-import org.apache.qpid.server.virtualhost.ExchangeIsAlternateException;
-import org.apache.qpid.server.virtualhost.HouseKeepingTask;
 import org.apache.qpid.server.virtualhost.NonStandardVirtualHost;
-import org.apache.qpid.server.virtualhost.RequiredExchangeException;
 import org.apache.qpid.server.virtualhost.VirtualHostImpl;
 
 /**
   Object that represents the VirtualHost whilst the VirtualHostNode is in the replica role.  The
   real virtualhost will be elsewhere in the group.
  */
-@ManagedObject( category = false, type = "BDB_HA_REPLICA", register = false )
-public class BDBHAReplicaVirtualHost extends AbstractConfiguredObject<BDBHAReplicaVirtualHost>
-    implements VirtualHostImpl<BDBHAReplicaVirtualHost, AMQQueue<?>, ExchangeImpl<?>>,
-               VirtualHost<BDBHAReplicaVirtualHost,AMQQueue<?>, ExchangeImpl<?>>,
-               NonStandardVirtualHost<BDBHAReplicaVirtualHost,AMQQueue<?>,ExchangeImpl<?>>
+public interface BDBHAReplicaVirtualHost<X extends BDBHAReplicaVirtualHost<X>>
+        extends VirtualHostImpl<X, AMQQueue<?>, ExchangeImpl<?>>,
+                NonStandardVirtualHost<X,AMQQueue<?>,ExchangeImpl<?>>
 {
-    private final StatisticsCounter _messagesDelivered, _dataDelivered, _messagesReceived, _dataReceived;
-
-    @ManagedAttributeField
-    private boolean _queue_deadLetterQueueEnabled;
-
-    @ManagedAttributeField
-    private long _housekeepingCheckPeriod;
-
-    @ManagedAttributeField
-    private long _storeTransactionIdleTimeoutClose;
-
-    @ManagedAttributeField
-    private long _storeTransactionIdleTimeoutWarn;
-
-    @ManagedAttributeField
-    private long _storeTransactionOpenTimeoutClose;
-
-    @ManagedAttributeField
-    private long _storeTransactionOpenTimeoutWarn;
-    @ManagedAttributeField
-    private int _housekeepingThreadCount;
-
-    @ManagedObjectFactoryConstructor
-    public BDBHAReplicaVirtualHost(final Map<String, Object> attributes, VirtualHostNode<?> virtualHostNode)
-    {
-        super(parentsMap(virtualHostNode), attributes);
-
-        _messagesDelivered = new StatisticsCounter("messages-delivered-" + getName());
-        _dataDelivered = new StatisticsCounter("bytes-delivered-" + getName());
-        _messagesReceived = new StatisticsCounter("messages-received-" + getName());
-        _dataReceived = new StatisticsCounter("bytes-received-" + getName());
-        setState(State.UNAVAILABLE);
-    }
-
-    @Override
-    protected void validateChange(final ConfiguredObject<?> proxyForValidation, final Set<String> changedAttributes)
-    {
-        super.validateChange(proxyForValidation, changedAttributes);
-
-        throwUnsupportedForReplica();
-    }
-
-    @Override
-    public String getModelVersion()
-    {
-        return BrokerModel.MODEL_VERSION;
-    }
-
-    @Override
-    protected <C extends ConfiguredObject> C addChild(final Class<C> childClass,
-                                                      final Map<String, Object> attributes,
-                                                      final ConfiguredObject... otherParents)
-    {
-        throwUnsupportedForReplica();
-        return null;
-    }
-
-    @Override
-    public ExchangeImpl createExchange(final Map<String, Object> attributes)
-    {
-        throwUnsupportedForReplica();
-        return null;
-    }
-
-    @Override
-    public void removeExchange(final ExchangeImpl<?> exchange, final boolean force)
-            throws ExchangeIsAlternateException, RequiredExchangeException
-    {
-        throwUnsupportedForReplica();
-    }
-
-    @Override
-    public MessageDestination getMessageDestination(final String name)
-    {
-        return null;
-    }
-
-    @Override
-    public ExchangeImpl<?> getExchange(final String name)
-    {
-        return null;
-    }
-
-    @Override
-    public AMQQueue<?> createQueue(final Map<String, Object> attributes)
-    {
-        throwUnsupportedForReplica();
-        return null;
-    }
-
-    @Override
-    public void executeTransaction(final TransactionalOperation op)
-    {
-        throwUnsupportedForReplica();
-    }
-
-    @Override
-    public Collection<String> getExchangeTypeNames()
-    {
-        return getObjectFactory().getSupportedTypes(Exchange.class);
-    }
-
-    @Override
-    public Collection<String> getSupportedExchangeTypes()
-    {
-        return getObjectFactory().getSupportedTypes(Exchange.class);
-    }
-
-    @Override
-    public Collection<String> getSupportedQueueTypes()
-    {
-        return getObjectFactory().getSupportedTypes(Queue.class);
-    }
-
-    @Override
-    public boolean isQueue_deadLetterQueueEnabled()
-    {
-        return false;
-    }
-
-    @Override
-    public long getHousekeepingCheckPeriod()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getStoreTransactionIdleTimeoutClose()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getStoreTransactionIdleTimeoutWarn()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getStoreTransactionOpenTimeoutClose()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getStoreTransactionOpenTimeoutWarn()
-    {
-        return 0;
-    }
-
-    @Override
-    public int getHousekeepingThreadCount()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getQueueCount()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getExchangeCount()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getConnectionCount()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getBytesIn()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getBytesOut()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getMessagesIn()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getMessagesOut()
-    {
-        return 0;
-    }
-
-    @Override
-    public Collection<VirtualHostAlias> getAliases()
-    {
-        return Collections.emptyList();
-    }
-
-    @Override
-    public Collection<Connection> getConnections()
-    {
-        return Collections.emptyList();
-    }
-
-    @Override
-    public IConnectionRegistry getConnectionRegistry()
-    {
-        return null;
-    }
-
-    @Override
-    public AMQQueue<?> getQueue(final String name)
-    {
-        return null;
-    }
-
-    @Override
-    public MessageSource getMessageSource(final String name)
-    {
-        return null;
-    }
-
-    @Override
-    public AMQQueue<?> getQueue(final UUID id)
-    {
-        return null;
-    }
-
-    @Override
-    public Collection<AMQQueue<?>> getQueues()
-    {
-        return Collections.emptyList();
-    }
-
-    @Override
-    public int removeQueue(final AMQQueue<?> queue)
-    {
-        throwUnsupportedForReplica();
-        return 0;
-    }
-
-    @Override
-    public Collection<ExchangeImpl<?>> getExchanges()
-    {
-        return Collections.emptyList();
-    }
-
-    @Override
-    public DurableConfigurationStore getDurableConfigurationStore()
-    {
-        return null;
-    }
-
-    @Override
-    public ExchangeImpl<?> getExchange(final UUID id)
-    {
-        return null;
-    }
-
-    @Override
-    public MessageDestination getDefaultDestination()
-    {
-        return null;
-    }
-
-    @Override
-    public MessageStore getMessageStore()
-    {
-        return null;
-    }
-
-    @Override
-    public void setTargetSize(final long targetSize)
-    {
-
-    }
-
-    @Override
-    public long getTotalQueueDepthBytes()
-    {
-        return 0l;
-    }
-
-    @Override
-    public org.apache.qpid.server.security.SecurityManager getSecurityManager()
-    {
-        return null;
-    }
-
-    @Override
-    public void scheduleHouseKeepingTask(final long period, final HouseKeepingTask task)
-    {
-    }
-
-    @Override
-    public long getHouseKeepingTaskCount()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getHouseKeepingCompletedTaskCount()
-    {
-        return 0;
-    }
-
-    @Override
-    public int getHouseKeepingPoolSize()
-    {
-        return 0;
-    }
-
-    @Override
-    public void setHouseKeepingPoolSize(final int newSize)
-    {
-    }
-
-    @Override
-    public int getHouseKeepingActiveCount()
-    {
-        return 0;
-    }
-
-    @Override
-    public DtxRegistry getDtxRegistry()
-    {
-        return null;
-    }
-
-    @Override
-    public LinkRegistry getLinkRegistry(final String remoteContainerId)
-    {
-        return null;
-    }
-
-    @Override
-    public ScheduledFuture<?> scheduleTask(final long delay, final Runnable timeoutTask)
-    {
-        throwUnsupportedForReplica();
-        return null;
-    }
-
-    @Override
-    public boolean getDefaultDeadLetterQueueEnabled()
-    {
-        return false;
-    }
-
-    @Override
-    public EventLogger getEventLogger()
-    {
-        return null;
-    }
-
-    @Override
-    public void registerMessageReceived(final long messageSize, final long timestamp)
-    {
-        throwUnsupportedForReplica();
-    }
-
-    @Override
-    public void registerMessageDelivered(final long messageSize)
-    {
-        throwUnsupportedForReplica();
-    }
-
-    @Override
-    public StatisticsCounter getMessageDeliveryStatistics()
-    {
-        return _messagesDelivered;
-    }
-
-    @Override
-    public StatisticsCounter getMessageReceiptStatistics()
-    {
-        return _messagesReceived;
-    }
-
-    @Override
-    public StatisticsCounter getDataDeliveryStatistics()
-    {
-        return _dataDelivered;
-    }
-
-    @Override
-    public StatisticsCounter getDataReceiptStatistics()
-    {
-        return _dataReceived;
-    }
-
-    @Override
-    public void resetStatistics()
-    {
-    }
-
-    private void throwUnsupportedForReplica()
-    {
-        throw new IllegalStateException("The virtual host state of " + getState()
-                                        + " does not permit this operation.");
-    }
-
 }

Copied: qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHostImpl.java (from r1648296, qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHost.java)
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHostImpl.java?p2=qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHostImpl.java&p1=qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHost.java&r1=1648296&r2=1648303&rev=1648303&view=diff
==============================================================================
--- qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHost.java (original)
+++ qpid/trunk/qpid/java/bdbstore/src/main/java/org/apache/qpid/server/virtualhost/berkeleydb/BDBHAReplicaVirtualHostImpl.java Mon Dec 29 10:28:02 2014
@@ -41,7 +41,6 @@ import org.apache.qpid.server.model.Mana
 import org.apache.qpid.server.model.ManagedObjectFactoryConstructor;
 import org.apache.qpid.server.model.Queue;
 import org.apache.qpid.server.model.State;
-import org.apache.qpid.server.model.VirtualHost;
 import org.apache.qpid.server.model.VirtualHostAlias;
 import org.apache.qpid.server.model.VirtualHostNode;
 import org.apache.qpid.server.protocol.LinkRegistry;
@@ -50,6 +49,7 @@ import org.apache.qpid.server.stats.Stat
 import org.apache.qpid.server.store.DurableConfigurationStore;
 import org.apache.qpid.server.store.MessageStore;
 import org.apache.qpid.server.txn.DtxRegistry;
+import org.apache.qpid.server.virtualhost.AbstractVirtualHost;
 import org.apache.qpid.server.virtualhost.ExchangeIsAlternateException;
 import org.apache.qpid.server.virtualhost.HouseKeepingTask;
 import org.apache.qpid.server.virtualhost.NonStandardVirtualHost;
@@ -61,10 +61,7 @@ import org.apache.qpid.server.virtualhos
   real virtualhost will be elsewhere in the group.
  */
 @ManagedObject( category = false, type = "BDB_HA_REPLICA", register = false )
-public class BDBHAReplicaVirtualHost extends AbstractConfiguredObject<BDBHAReplicaVirtualHost>
-    implements VirtualHostImpl<BDBHAReplicaVirtualHost, AMQQueue<?>, ExchangeImpl<?>>,
-               VirtualHost<BDBHAReplicaVirtualHost,AMQQueue<?>, ExchangeImpl<?>>,
-               NonStandardVirtualHost<BDBHAReplicaVirtualHost,AMQQueue<?>,ExchangeImpl<?>>
+public class BDBHAReplicaVirtualHostImpl extends AbstractConfiguredObject<BDBHAReplicaVirtualHostImpl> implements BDBHAReplicaVirtualHost<BDBHAReplicaVirtualHostImpl>
 {
     private final StatisticsCounter _messagesDelivered, _dataDelivered, _messagesReceived, _dataReceived;
 
@@ -89,7 +86,7 @@ public class BDBHAReplicaVirtualHost ext
     private int _housekeepingThreadCount;
 
     @ManagedObjectFactoryConstructor
-    public BDBHAReplicaVirtualHost(final Map<String, Object> attributes, VirtualHostNode<?> virtualHostNode)
+    public BDBHAReplicaVirtualHostImpl(final Map<String, Object> attributes, VirtualHostNode<?> virtualHostNode)
     {
         super(parentsMap(virtualHostNode), attributes);
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org