[arrow-datafusion] branch master updated: make datafusion-proto match exhaustive (#2567)

[ag...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

agrove pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git


The following commit(s) were added to refs/heads/master by this push:
     new 635d659c0 make datafusion-proto match exhaustive (#2567)
635d659c0 is described below

commit 635d659c0517bc033aa78405496b49c3bf6e760f
Author: Andy Grove <ag...@apache.org>
AuthorDate: Wed May 18 08:03:39 2022 -0600

    make datafusion-proto match exhaustive (#2567)
---
 datafusion/proto/src/to_proto.rs | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/datafusion/proto/src/to_proto.rs b/datafusion/proto/src/to_proto.rs
index 5970a3c30..a5f6ffbb0 100644
--- a/datafusion/proto/src/to_proto.rs
+++ b/datafusion/proto/src/to_proto.rs
@@ -713,7 +713,15 @@ impl TryFrom<&Expr> for protobuf::LogicalExprNode {
             Expr::Wildcard => Self {
                 expr_type: Some(ExprType::Wildcard(true)),
             },
-            _ => unimplemented!(),
+            Expr::ScalarSubquery(_) | Expr::InSubquery { .. } | Expr::Exists { .. } => {
+                // we would need to add logical plan operators to datafusion.proto to support this
+                // see discussion in https://github.com/apache/arrow-datafusion/issues/2565
+                unimplemented!("subquery expressions are not supported yet")
+            }
+            Expr::QualifiedWildcard { .. }
+            | Expr::GetIndexedField { .. }
+            | Expr::TryCast { .. }
+            | Expr::GroupingSet(_) => unimplemented!(),
         };
 
         Ok(expr_node)