You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/15 03:33:31 UTC

[I] [Studio][Bug] Reject duplicate instance provider registrations [rocketmq-dashboard]

yyqdbngt opened a new issue, #2213:
URL: https://github.com/apache/rocketmq-dashboard/issues/2213

   ## Problem
   
   `InstanceProviderRegistry` registers providers and cloud catalogs by repeatedly calling `EnumMap.put`. If two Spring beans claim the same `InstanceVendor`, the later bean silently replaces the earlier one. The selected implementation then depends on dependency-injection ordering, which makes a configuration error difficult to diagnose and can route requests to an unintended provider.
   
   ## Proposed scope
   
   - Fail fast while constructing the registry when duplicate instance providers claim a vendor.
   - Apply the same validation to duplicate cloud catalog providers.
   - Include the vendor in a stable, actionable exception message.
   - Add focused tests for normal registration and both duplicate cases.
   
   ## Expected behavior
   
   At most one provider and one catalog may be registered for each vendor, and ambiguous registrations should stop application startup deterministically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Reject duplicate instance provider registrations [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #2213:
URL: https://github.com/apache/rocketmq-dashboard/issues/2213#issuecomment-5300447454

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The reported issue has been verified against the current codebase.
   
   **Root Cause:** `InstanceProviderRegistry` constructor uses `providerList.forEach(provider -> providers.put(provider.vendor(), provider))` and the same pattern for catalogs. `EnumMap.put` silently replaces existing entries, so if two Spring beans claim the same `InstanceVendor`, the last one wins without any warning or error. The selected implementation depends on Spring's bean ordering, making misconfiguration hard to diagnose.
   
   **Impact:** Duplicate provider registrations silently route requests to an unintended implementation. Configuration errors are not caught at startup.
   
   **Severity:** medium
   
   An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation.
   
   ---
   *Automated evaluation by github-manager-bot*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Reject duplicate instance provider registrations [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #2213:
URL: https://github.com/apache/rocketmq-dashboard/issues/2213#issuecomment-5383289705

   This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Reject duplicate instance provider registrations [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #2213: [Studio][Bug] Reject duplicate instance provider registrations
URL: https://github.com/apache/rocketmq-dashboard/issues/2213


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org