You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/03/27 23:51:23 UTC
[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21212
Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes
......................................................................
[rpc] relax settings for MeasureAcceptorDispatchTimes
On some nodes, RpcAcceptorBench.MeasureAcceptorDispatchTimes might
run out of file descriptors if run with 16 concurrent client threads,
failing the test. This patch modifies the default settings for the
scenario to run with just a single client thread by default. That's
enough to provide good coverage for the related metrics while easing
the load on a test node.
Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f
---
M src/kudu/rpc/rpc-bench.cc
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/21212/1
--
To view, visit http://gerrit.cloudera.org:8080/21212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f
Gerrit-Change-Number: 21212
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f
Gerrit-Change-Number: 21212
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21212 )
Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f
Gerrit-Change-Number: 21212
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2024 18:32:02 +0000
Gerrit-HasComments: No
[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21212 )
Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21212/1/src/kudu/rpc/rpc-bench.cc
File src/kudu/rpc/rpc-bench.cc:
http://gerrit.cloudera.org:8080/#/c/21212/1/src/kudu/rpc/rpc-bench.cc@354
PS1, Line 354: for (auto i = 0; i < threads_num; ++i) {
> As you could see from the commit description, the change in the default set
Ah, okay thanks for the explanation.
--
To view, visit http://gerrit.cloudera.org:8080/21212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f
Gerrit-Change-Number: 21212
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2024 18:37:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21212 )
Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21212/1/src/kudu/rpc/rpc-bench.cc
File src/kudu/rpc/rpc-bench.cc:
http://gerrit.cloudera.org:8080/#/c/21212/1/src/kudu/rpc/rpc-bench.cc@354
PS1, Line 354: for (auto i = 0; i < threads_num; ++i) {
> Do we want to get rid of this loop and modify other areas of this test sinc
As you could see from the commit description, the change in the default setting for 'client_threads' is just to conserve computational resources when running this test as a part of pre-commit verification make this test passing even with lower setting of 'ulimit -n'.
However, rpc-bench is also used in various benchmarks. For the latter, we this test scenario provides much more insights on performance if run with multiple client threads. With --client_threads=1 it just does basic verification of the 'reactor_active_latency_us' metric.
--
To view, visit http://gerrit.cloudera.org:8080/21212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f
Gerrit-Change-Number: 21212
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 28 Mar 2024 16:27:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21212 )
Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes
......................................................................
[rpc] relax settings for MeasureAcceptorDispatchTimes
On some nodes, RpcAcceptorBench.MeasureAcceptorDispatchTimes might
run out of file descriptors if run with 16 concurrent client threads,
failing the test. This patch modifies the default settings for the
scenario to run with just a single client thread by default. That's
enough to provide good coverage for the related metrics while easing
the load on a test node.
Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f
Reviewed-on: http://gerrit.cloudera.org:8080/21212
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/rpc/rpc-bench.cc
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Mahesh Reddy: Looks good to me, but someone else must approve
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f
Gerrit-Change-Number: 21212
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21212 )
Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes
......................................................................
Patch Set 2: Verified+1
unrelated test failures
--
To view, visit http://gerrit.cloudera.org:8080/21212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f
Gerrit-Change-Number: 21212
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2024 19:13:13 +0000
Gerrit-HasComments: No
[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21212 )
Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21212/1/src/kudu/rpc/rpc-bench.cc
File src/kudu/rpc/rpc-bench.cc:
http://gerrit.cloudera.org:8080/#/c/21212/1/src/kudu/rpc/rpc-bench.cc@354
PS1, Line 354: for (auto i = 0; i < threads_num; ++i) {
Do we want to get rid of this loop and modify other areas of this test since we only have one thread now or leave it as is in case we want to increase the number of threads in future for any reason?
--
To view, visit http://gerrit.cloudera.org:8080/21212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f
Gerrit-Change-Number: 21212
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 28 Mar 2024 06:19:05 +0000
Gerrit-HasComments: Yes