You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Jakob Homan (Jira)" <ji...@apache.org> on 2019/09/13 22:30:00 UTC

[jira] [Created] (AIRFLOW-5490) security.py: Fix incorrect None comparison

Jakob Homan created AIRFLOW-5490:
------------------------------------

             Summary: security.py: Fix incorrect None comparison
                 Key: AIRFLOW-5490
                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5490
             Project: Apache Airflow
          Issue Type: Bug
          Components: security
    Affects Versions: 1.10.6
            Reporter: Jakob Homan


Note: This ticket's being created to facilitate a new contributor's workshop for Airflow. After the workshop has completed, I'll mark these all available for anyone that might like to take them on.

In security.py, we twice use ``==`` with ``None``, which is [not correct|https://stackoverflow.com/a/3257957]

airflow/www/security.py:343
{code:python}
sqla_models.PermissionView.permission == None,  # noqa pylint: disable=singleton-comparison
    sqla_models.PermissionView.view_menu == None,  # noqa pylint: disable=singleton-comparison
)) {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)