You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by cn...@apache.org on 2014/09/21 05:53:22 UTC
git commit: HDFS-7107. Avoid Findbugs warning for synchronization on
AbstractNNFailoverProxyProvider#fallbackToSimpleAuth. Contributed by Chris
Nauroth.
Repository: hadoop
Updated Branches:
refs/heads/trunk 84a0a629d -> 47491f9a1
HDFS-7107. Avoid Findbugs warning for synchronization on AbstractNNFailoverProxyProvider#fallbackToSimpleAuth. Contributed by Chris Nauroth.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/47491f9a
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/47491f9a
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/47491f9a
Branch: refs/heads/trunk
Commit: 47491f9a119faf75abaa56f676ae93460583bd3f
Parents: 84a0a62
Author: cnauroth <cn...@apache.org>
Authored: Sat Sep 20 20:53:09 2014 -0700
Committer: cnauroth <cn...@apache.org>
Committed: Sat Sep 20 20:53:09 2014 -0700
----------------------------------------------------------------------
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 3 +++
.../server/namenode/ha/AbstractNNFailoverProxyProvider.java | 6 ++++--
2 files changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hadoop/blob/47491f9a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
index 9fa06d4..dfdc21f 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
+++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
@@ -905,6 +905,9 @@ Release 2.6.0 - UNRELEASED
HDFS-7105. Allow falling back to a non-SASL connection on
DataTransferProtocol in several edge cases. (cnauroth)
+ HDFS-7107. Avoid Findbugs warning for synchronization on
+ AbstractNNFailoverProxyProvider#fallbackToSimpleAuth. (cnauroth)
+
Release 2.5.1 - 2014-09-05
INCOMPATIBLE CHANGES
http://git-wip-us.apache.org/repos/asf/hadoop/blob/47491f9a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/AbstractNNFailoverProxyProvider.java
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/AbstractNNFailoverProxyProvider.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/AbstractNNFailoverProxyProvider.java
index 08e82be..a0aa10b 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/AbstractNNFailoverProxyProvider.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/AbstractNNFailoverProxyProvider.java
@@ -38,12 +38,14 @@ public abstract class AbstractNNFailoverProxyProvider<T> implements
public abstract boolean useLogicalURI();
/**
- * Set for tracking if a secure client falls back to simple auth.
+ * Set for tracking if a secure client falls back to simple auth. This method
+ * is synchronized only to stifle a Findbugs warning.
*
* @param fallbackToSimpleAuth - set to true or false during this method to
* indicate if a secure client falls back to simple auth
*/
- public void setFallbackToSimpleAuth(AtomicBoolean fallbackToSimpleAuth) {
+ public synchronized void setFallbackToSimpleAuth(
+ AtomicBoolean fallbackToSimpleAuth) {
this.fallbackToSimpleAuth = fallbackToSimpleAuth;
}
}