You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/01 04:46:56 UTC
[GitHub] [apisix] anjia0532 opened a new pull request #4954: doc : change prometheus scrape interval
anjia0532 opened a new pull request #4954:
URL: https://github.com/apache/apisix/pull/4954
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
prometheus default scrape interval is 1min(60s) , but promql expression use 30s and 1m(min) , data may not be available.
https://github.com/apache/apisix/blob/master/docs/assets/other/json/apisix-grafana-dashboard.json#L521-L527
https://github.com/apache/apisix/blob/master/docs/assets/other/json/apisix-grafana-dashboard.json#L621-L632
https://github.com/apache/apisix/blob/master/docs/assets/other/json/apisix-grafana-dashboard.json#L726-L738
https://github.com/apache/apisix/blob/master/docs/assets/other/json/apisix-grafana-dashboard.json#L854-L863
https://github.com/apache/apisix/blob/master/docs/assets/other/json/apisix-grafana-dashboard.json#L966-L981
...
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4954: docs: change prometheus scrape interval
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4954:
URL: https://github.com/apache/apisix/pull/4954#discussion_r699893092
##########
File path: docs/en/latest/plugins/prometheus.md
##########
@@ -106,6 +106,7 @@ For example like this:
```yaml
scrape_configs:
- job_name: 'apisix'
+ scrape_interval: 20s
Review comment:
The prometheus configuration is just an example, doesn't mean we suggest people do like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed pull request #4954: docs: change prometheus scrape interval
Posted by GitBox <gi...@apache.org>.
spacewander closed pull request #4954:
URL: https://github.com/apache/apisix/pull/4954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4954: docs: change prometheus scrape interval
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4954:
URL: https://github.com/apache/apisix/pull/4954#discussion_r699893092
##########
File path: docs/en/latest/plugins/prometheus.md
##########
@@ -106,6 +106,7 @@ For example like this:
```yaml
scrape_configs:
- job_name: 'apisix'
+ scrape_interval: 20s
Review comment:
The prometheus configuration is just an example, doesn't mean we suggest people do like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] anjia0532 commented on a change in pull request #4954: docs: change prometheus scrape interval
Posted by GitBox <gi...@apache.org>.
anjia0532 commented on a change in pull request #4954:
URL: https://github.com/apache/apisix/pull/4954#discussion_r700129470
##########
File path: docs/en/latest/plugins/prometheus.md
##########
@@ -106,6 +106,7 @@ For example like this:
```yaml
scrape_configs:
- job_name: 'apisix'
+ scrape_interval: 20s
Review comment:
但是dashboard.json使用了大量的30秒和1分钟的表达式，会导致导入dashboard后，没有数据，没有达到开箱即用的初衷（尤其是对于grafana和prometheus不是特别熟悉的人来说）。即使不加到yaml配置文件里，也可以考虑在文档说明一下。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed pull request #4954: docs: change prometheus scrape interval
Posted by GitBox <gi...@apache.org>.
spacewander closed pull request #4954:
URL: https://github.com/apache/apisix/pull/4954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org