[GitHub] [commons-csv] garydgregory commented on a change in pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#discussion_r668343890



##########
File path: src/main/java/org/apache/commons/csv/ExtendedBufferedReader.java
##########
@@ -132,10 +132,24 @@ int lookAhead() throws IOException {
      */
     char[] lookAhead(final int n) throws IOException {
         final char[] buf = new char[n];

Review comment:
       The local var is not needed anymore right?

##########
File path: src/main/java/org/apache/commons/csv/Lexer.java
##########
@@ -153,25 +156,26 @@ boolean isEscape(final int ch) {
     }
 
     /**
-     * Tests if the next characters constitute a escape delimiter through {@link ExtendedBufferedReader#lookAhead(int)}.
+     * Tests if the next characters constitute a escape delimiter through
+     * {@link ExtendedBufferedReader#lookAhead(char[])}.
      *

Review comment:
       Same comment.

##########
File path: src/main/java/org/apache/commons/csv/Lexer.java
##########
@@ -112,25 +116,24 @@ boolean isCommentStart(final int ch) {
     }
 
     /**
-     * Determine whether the next characters constitute a delimiter through {@link ExtendedBufferedReader#lookAhead(int)}
+     * Determine whether the next characters constitute a delimiter through

Review comment:
       No need to change for formatted, it makes more noise to review.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org