You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by "Matthias Reischenbacher (JIRA)" <ji...@apache.org> on 2015/05/06 13:54:00 UTC
[jira] [Commented] (FOP-1488) [PATCH] orphans/widows not respected
in some cases
[ https://issues.apache.org/jira/browse/FOP-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530408#comment-14530408 ]
Matthias Reischenbacher commented on FOP-1488:
----------------------------------------------
Thanks a lot Andreas for updating your patch. I updated my fop code base some weeks ago and had difficulties correctly applying your changes.
This patch has been very useful for my clients, the only minor thing which still needs to be addressed, is the line counting when images are used. If there are several images, one after each other, they are all hold together if a high orphans/widows value is used, because each image is counted as one line. If the images are very high, it can easily happen that the images overflow the page. Would it be correct (from a xsl-fo standard's point of view) to handle the line counting for images differently?
> [PATCH] orphans/widows not respected in some cases
> --------------------------------------------------
>
> Key: FOP-1488
> URL: https://issues.apache.org/jira/browse/FOP-1488
> Project: Fop
> Issue Type: Bug
> Components: unqualified
> Affects Versions: trunk
> Environment: Operating System: All
> Platform: All
> Reporter: Andrew McFarland
> Attachments: FOP-1488-code.patch, FOP-1488-test.patch, b44328.patch, b44328.patch, b44328.patch, b44328.patch, b44328.patch, b44328.patch, b44328.patch, b44328_test.patch, block_orphans_widows.fo, block_orphans_widows.fo, block_orphans_widows.fo, block_orphans_widows.fo, block_orphans_widows.fo, widow.fo
>
>
> When I process the following fo, I get a PDF with a one-line widow at the start
> of the second page, even though widows for that fo:block is set to 4.
> <?xml version="1.0" encoding="ISO-8859-1"?>
> <fo:root xmlns:fo="http://www.w3.org/1999/XSL/Format">
> <fo:layout-master-set>
> <fo:simple-page-master master-name="A4">
> <fo:region-body />
> </fo:simple-page-master>
> </fo:layout-master-set>
> <fo:page-sequence master-reference="A4">
> <fo:flow flow-name="xsl-region-body">
> <fo:block>Paragraph</fo:block>
> <fo:block>Paragraph</fo:block>
> <fo:block>Paragraph</fo:block>
> <fo:block>Paragraph</fo:block>
> <fo:block>Paragraph</fo:block>
> <fo:block>Paragraph</fo:block>
> <fo:block>Paragraph</fo:block>
> <fo:block>Paragraph</fo:block>
> <fo:block>Paragraph</fo:block>
> <fo:block>Paragraph</fo:block>
> <fo:block>Paragraph</fo:block>
> <fo:block>Paragraph</fo:block>
> <fo:block>Paragraph</fo:block>
> <fo:block widows="4" linefeed-treatment="preserve" >line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> line
> </fo:block>
> </fo:flow>
> </fo:page-sequence>
> </fo:root>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)