You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/27 06:45:11 UTC

[GitHub] [inlong] github-code-scanning[bot] commented on a diff in pull request #5225: [INLONG-5014][Improve] Fix the code scanning alerts exposed by CodeQL

github-code-scanning[bot] commented on code in PR #5225:
URL: https://github.com/apache/inlong/pull/5225#discussion_r930678061


##########
inlong-tubemq/tubemq-server/src/main/java/org/apache/inlong/tubemq/server/master/web/MasterStatusCheckFilter.java:
##########
@@ -65,7 +70,9 @@
             if (TStringUtils.isNotBlank(req.getQueryString())) {
                 sBuilder.append("?").append(req.getQueryString());
             }
-            resp.sendRedirect(sBuilder.toString());
+            if (sBuilder.toString().startsWith(redirectWhiteList)) {
+                resp.sendRedirect(sBuilder.toString());

Review Comment:
   ## URL redirection from remote source
   
   Potentially untrusted URL redirection due to [user-provided value](1).
   Potentially untrusted URL redirection due to [user-provided value](2).
   
   [Show more details](https://github.com/apache/inlong/security/code-scanning/36)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org