Re: [PR] KAFKA-19883: [DRAFT] KIP-1289 — Transactional acknowledgments for share groups (state + client API + wire schema) [kafka]

["Shekharrajak (via GitHub)" <gi...@apache.org>]

Shekharrajak commented on code in PR #22357:
URL: https://github.com/apache/kafka/pull/22357#discussion_r4180537040


##########
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:
##########
@@ -1151,6 +1153,8 @@ private AbstractRequest getRequest(ApiKeys apikey, short version) {
             case SHARE_FETCH: return createShareFetchRequest(version);
             case SHARE_ACKNOWLEDGE: return createShareAcknowledgeRequest(version);
             case TXN_SHARE_ACKNOWLEDGE: return createTxnShareAcknowledgeRequest(version);
+            case VALIDATE_SHARE_GROUP_MEMBER: return new ValidateShareGroupMemberRequest.Builder(
+                new ValidateShareGroupMemberRequestData().setGroupId("share").setMemberId("member").setMemberEpoch(4)).build(version);

Review Comment:
   validation and fencing 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org