[GitHub] [trafficcontrol] ocket8888 opened a new pull request #3624: Removed restangular from PhysLocationService

[GitBox <gi...@apache.org>]

ocket8888 opened a new pull request #3624: Removed restangular from PhysLocationService
URL: https://github.com/apache/trafficcontrol/pull/3624
 
 
   ## What does this PR (Pull Request) do?
   Removes a dependency on Restangular from the "PhysLocationService"
   - [x] This PR partially addresses #3571 
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Portal
   
   Traffic Portal dependencies are not individually documented, and so no documentation changes are necessary.
   
   ## What is the best way to verify this PR?
   
   No functionality should have changed (except that errors will now be logged instead of ignored in many cases), so the existing tests should all pass.
   
   Jeremy: actually, the only way to truly verify that the functionality did not change is to:
   
   1. run the UI tests (which is a very small subset of all TP functionality)
   2. manually verify the functionality associated with ALL the services functions that changed just to be sure all is well.
   
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services