[GitHub] [commons-codec] aherbert commented on issue #24: Base64 should be open for different alphabets

[GitBox <gi...@apache.org>]

aherbert commented on issue #24: Base64 should be open for different alphabets
URL: https://github.com/apache/commons-codec/pull/24#issuecomment-514386084
 
 
   I think the build fails because the maven-javadoc-plugin configuration section in build does not have this:
   ```
   <source>${maven.compiler.source}</source>
   ```
   The plugin is configured in commons-parent. It has this tag for the reporting section and the release profile but not for the build section.
   
   @cljk Can you confirm that you cannot do this with Corretto JDK 11:
   ```
   mvn javadoc:javadoc
   
   or default goal
   
   mvn
   ```
   
   This should work:
   
   ```
   mvn javadoc:javadoc -Dsource=1.7
   ```
   
   On the code change, do not make the array public. The values are mutable. Copy the array to the unit test or provide a package private level static getter which returns a clone of the array.
   
   You should also change the public constructor that accepts an input alphabet to check it has 64 characters. I'm not sure where we are with defensive copying of input arrays so I'll leave that judgement for someone else.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services