You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Yukang-Lian (via GitHub)" <gi...@apache.org> on 2026/01/28 09:46:07 UTC
[PR] [DO NOT MERGE]JUST TEST [doris]
Yukang-Lian opened a new pull request, #60310:
URL: https://github.com/apache/doris/pull/60310
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3823987233
# BE Regression && UT Coverage Report
Increment line coverage `84.09% (148/176)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_006d993f151aa35a8607afc0d9941d132aa8033e_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_006d993f151aa35a8607afc0d9941d132aa8033e_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.54% (25759/36004) |
| Line Coverage | 54.22% (269367/496779) |
| Region Coverage | 51.94% (225267/433718) |
| Branch Coverage | 53.24% (96403/181079) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3821858791
# FE UT Coverage Report
Increment line coverage `` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_5d2f93cc6fadb41cb7688e2ac0518abc657fe240/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_5d2f93cc6fadb41cb7688e2ac0518abc657fe240/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3840343987
# Cloud UT Coverage Report
Increment line coverage `68.89% (62/90)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/159ab4d7cbe585e36ff37f1f25f93c83b22ff4b5_159ab4d7cbe585e36ff37f1f25f93c83b22ff4b5_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/159ab4d7cbe585e36ff37f1f25f93c83b22ff4b5_159ab4d7cbe585e36ff37f1f25f93c83b22ff4b5_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.30% (1793/2261) |
| Line Coverage | 64.76% (31896/49251) |
| Region Coverage | 65.41% (15923/24344) |
| Branch Coverage | 55.95% (8467/15134) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3819721886
<details>
<summary>TPC-H: <b>Total hot run time: 32338 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 45e7d1fbb71cfe904b139878d2e4f80352f77f1a, data reload: false
------ Round 1 ----------------------------------
q1 17652 5282 5080 5080
q2 1997 321 211 211
q3 10202 1310 745 745
q4 10205 840 311 311
q5 7487 2148 1946 1946
q6 204 182 147 147
q7 882 755 607 607
q8 9282 1395 1111 1111
q9 5560 4853 4793 4793
q10 6904 1965 1562 1562
q11 550 290 286 286
q12 398 377 227 227
q13 17802 4059 3230 3230
q14 240 235 209 209
q15 916 833 823 823
q16 661 685 621 621
q17 834 842 424 424
q18 7501 6722 7298 6722
q19 1607 1041 635 635
q20 422 370 244 244
q21 3022 2219 2087 2087
q22 359 384 317 317
Total cold run time: 104687 ms
Total hot run time: 32338 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5723 5614 5616 5614
q2 274 332 244 244
q3 2371 2894 2473 2473
q4 1466 1889 1386 1386
q5 4744 4629 4564 4564
q6 221 187 140 140
q7 2067 1980 1790 1790
q8 2571 2348 2454 2348
q9 7540 7470 7375 7375
q10 2799 3050 2681 2681
q11 551 473 448 448
q12 638 756 629 629
q13 3924 4072 3212 3212
q14 282 282 269 269
q15 846 814 802 802
q16 639 686 645 645
q17 1084 1244 1267 1244
q18 7573 7204 7314 7204
q19 831 795 832 795
q20 1981 2033 1890 1890
q21 4535 4100 4112 4100
q22 600 560 495 495
Total cold run time: 53260 ms
Total hot run time: 50348 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3820206198
# BE UT Coverage Report
Increment line coverage `7.98% (15/188)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/45e7d1fbb71cfe904b139878d2e4f80352f77f1a_45e7d1fbb71cfe904b139878d2e4f80352f77f1a/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/45e7d1fbb71cfe904b139878d2e4f80352f77f1a_45e7d1fbb71cfe904b139878d2e4f80352f77f1a/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.74% (19279/36558) |
| Line Coverage | 36.12% (179160/495960) |
| Region Coverage | 32.55% (138956/426866) |
| Branch Coverage | 33.52% (60133/179421) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3841171329
# BE UT Coverage Report
Increment line coverage `55.61% (109/196)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/159ab4d7cbe585e36ff37f1f25f93c83b22ff4b5_159ab4d7cbe585e36ff37f1f25f93c83b22ff4b5/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/159ab4d7cbe585e36ff37f1f25f93c83b22ff4b5_159ab4d7cbe585e36ff37f1f25f93c83b22ff4b5/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.59% (19384/36856) |
| Line Coverage | 36.05% (179987/499322) |
| Region Coverage | 32.44% (139768/430878) |
| Branch Coverage | 33.40% (60409/180889) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3847088843
# BE UT Coverage Report
Increment line coverage `71.14% (143/201)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/0084d8c94efd40698d8591000d2f64d7f07404c7_0084d8c94efd40698d8591000d2f64d7f07404c7/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/0084d8c94efd40698d8591000d2f64d7f07404c7_0084d8c94efd40698d8591000d2f64d7f07404c7/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.58% (19386/36870) |
| Line Coverage | 36.07% (180105/499387) |
| Region Coverage | 32.45% (139847/430938) |
| Branch Coverage | 33.42% (60460/180885) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3884759051
<details>
<summary>ClickBench: <b>Total hot run time: 28.98 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7d04b2c55fbe829e25ca2c317fe453a0321221bf, data reload: false
query1 0.05 0.04 0.04
query2 0.10 0.05 0.05
query3 0.25 0.09 0.08
query4 1.61 0.11 0.11
query5 0.25 0.24 0.24
query6 1.17 0.70 0.67
query7 0.03 0.02 0.02
query8 0.06 0.04 0.04
query9 0.56 0.51 0.49
query10 0.54 0.54 0.56
query11 0.15 0.09 0.10
query12 0.15 0.10 0.11
query13 0.63 0.61 0.63
query14 1.06 1.05 1.07
query15 0.88 0.86 0.85
query16 0.39 0.40 0.40
query17 1.16 1.16 1.18
query18 0.23 0.20 0.21
query19 2.09 1.94 2.01
query20 0.02 0.01 0.02
query21 15.41 0.26 0.15
query22 5.31 0.06 0.05
query23 15.98 0.29 0.12
query24 1.61 0.27 0.26
query25 0.11 0.09 0.06
query26 0.15 0.14 0.13
query27 0.07 0.06 0.08
query28 3.38 1.15 0.99
query29 12.62 4.00 3.20
query30 0.29 0.13 0.11
query31 2.82 0.64 0.40
query32 3.24 0.58 0.50
query33 3.26 3.25 3.35
query34 16.13 5.44 4.74
query35 4.73 5.35 5.35
query36 0.69 0.56 0.54
query37 0.13 0.07 0.07
query38 0.08 0.04 0.04
query39 0.05 0.03 0.03
query40 0.19 0.18 0.15
query41 0.08 0.03 0.03
query42 0.05 0.03 0.03
query43 0.04 0.03 0.04
Total cold run time: 97.8 s
Total hot run time: 28.98 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3822344797
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3858083504
# BE Regression && UT Coverage Report
Increment line coverage `92.59% (175/189)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_4d3741931e91c2c543f1ed8d076ff29efcc64a84_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_4d3741931e91c2c543f1ed8d076ff29efcc64a84_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.34% (26502/36137) |
| Line Coverage | 56.45% (281284/498278) |
| Region Coverage | 54.32% (236511/435400) |
| Branch Coverage | 55.84% (101442/181650) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3853237046
# BE UT Coverage Report
Increment line coverage `71.14% (143/201)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/4d3741931e91c2c543f1ed8d076ff29efcc64a84_4d3741931e91c2c543f1ed8d076ff29efcc64a84/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/4d3741931e91c2c543f1ed8d076ff29efcc64a84_4d3741931e91c2c543f1ed8d076ff29efcc64a84/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.61% (19401/36877) |
| Line Coverage | 36.08% (180209/499478) |
| Region Coverage | 32.47% (139952/430985) |
| Branch Coverage | 33.44% (60499/180918) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #60310:
URL: https://github.com/apache/doris/pull/60310#discussion_r2791939433
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -2553,6 +2553,43 @@ void MetaServiceImpl::prepare_rowset(::google::protobuf::RpcController* controll
return;
}
+ // Record the BE's cluster_id in TxnInfoPB for compaction read-write separation.
+ // prepare_rowset is called by BE directly, so cloud_unique_id is the BE's.
+ // commit_txn is called by FE, so we store the cluster_id here for later use.
+ if (rowset_meta.has_load_id()) {
Review Comment:
there are performance issues
we should not touch these kvs every time we prepare rowset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #60310:
URL: https://github.com/apache/doris/pull/60310#discussion_r2792080581
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -2553,6 +2553,43 @@ void MetaServiceImpl::prepare_rowset(::google::protobuf::RpcController* controll
return;
}
+ // Record the BE's cluster_id in TxnInfoPB for compaction read-write separation.
+ // prepare_rowset is called by BE directly, so cloud_unique_id is the BE's.
+ // commit_txn is called by FE, so we store the cluster_id here for later use.
+ if (rowset_meta.has_load_id()) {
Review Comment:
store load cluster id when begin_txn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3885721996
# FE Regression Coverage Report
Increment line coverage ` 55.56% (5/9)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_7d04b2c55fbe829e25ca2c317fe453a0321221bf_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_7d04b2c55fbe829e25ca2c317fe453a0321221bf_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3857776843
run nonConcurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3858390146
run nonConcurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3822864312
<details>
<summary>ClickBench: <b>Total hot run time: 28.89 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 006d993f151aa35a8607afc0d9941d132aa8033e, data reload: false
query1 0.05 0.05 0.05
query2 0.11 0.04 0.04
query3 0.26 0.08 0.09
query4 1.61 0.12 0.11
query5 0.26 0.23 0.24
query6 1.18 0.68 0.66
query7 0.03 0.02 0.03
query8 0.04 0.04 0.04
query9 0.57 0.51 0.50
query10 0.53 0.54 0.55
query11 0.15 0.09 0.10
query12 0.14 0.10 0.10
query13 0.62 0.62 0.61
query14 1.06 1.06 1.07
query15 0.87 0.85 0.86
query16 0.42 0.39 0.40
query17 1.08 1.15 1.17
query18 0.23 0.22 0.22
query19 2.09 2.05 2.05
query20 0.02 0.01 0.01
query21 15.60 0.26 0.14
query22 4.73 0.06 0.05
query23 15.78 0.29 0.10
query24 1.77 0.22 0.41
query25 0.10 0.06 0.06
query26 0.16 0.13 0.13
query27 0.07 0.06 0.06
query28 4.37 1.15 0.97
query29 12.59 3.93 3.17
query30 0.27 0.13 0.11
query31 2.81 0.63 0.41
query32 3.24 0.59 0.51
query33 3.19 3.24 3.34
query34 15.98 5.37 4.71
query35 4.80 5.36 5.31
query36 0.70 0.57 0.53
query37 0.14 0.07 0.07
query38 0.09 0.04 0.04
query39 0.05 0.02 0.03
query40 0.20 0.18 0.17
query41 0.08 0.03 0.02
query42 0.05 0.02 0.03
query43 0.04 0.03 0.04
Total cold run time: 98.13 s
Total hot run time: 28.89 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3840873529
<details>
<summary>ClickBench: <b>Total hot run time: 27.96 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 159ab4d7cbe585e36ff37f1f25f93c83b22ff4b5, data reload: false
query1 0.06 0.04 0.04
query2 0.13 0.06 0.06
query3 0.30 0.08 0.07
query4 1.61 0.10 0.10
query5 0.26 0.25 0.24
query6 1.14 0.65 0.63
query7 0.03 0.02 0.02
query8 0.07 0.05 0.06
query9 0.59 0.50 0.50
query10 0.54 0.55 0.56
query11 0.25 0.13 0.13
query12 0.26 0.14 0.15
query13 0.62 0.62 0.61
query14 0.98 0.97 0.98
query15 0.90 0.81 0.82
query16 0.40 0.39 0.40
query17 1.05 0.99 1.05
query18 0.24 0.22 0.22
query19 1.95 1.88 1.88
query20 0.02 0.02 0.01
query21 15.40 0.28 0.24
query22 5.04 0.10 0.09
query23 15.39 0.40 0.22
query24 2.35 0.50 0.34
query25 0.10 0.10 0.10
query26 0.18 0.18 0.17
query27 0.09 0.09 0.09
query28 3.71 1.13 0.96
query29 12.51 4.01 3.27
query30 0.33 0.13 0.11
query31 2.80 0.67 0.44
query32 3.24 0.62 0.49
query33 3.02 3.11 3.08
query34 15.92 5.06 4.43
query35 4.49 4.50 4.54
query36 0.62 0.49 0.50
query37 0.25 0.09 0.09
query38 0.22 0.06 0.06
query39 0.07 0.06 0.05
query40 0.19 0.17 0.16
query41 0.14 0.06 0.07
query42 0.08 0.05 0.05
query43 0.08 0.06 0.06
Total cold run time: 97.62 s
Total hot run time: 27.96 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3840148031
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3884078066
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3841646046
# BE Regression && UT Coverage Report
Increment line coverage `52.17% (96/184)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_159ab4d7cbe585e36ff37f1f25f93c83b22ff4b5_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_159ab4d7cbe585e36ff37f1f25f93c83b22ff4b5_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 57.39% (20729/36117) |
| Line Coverage | 40.29% (200712/498112) |
| Region Coverage | 37.36% (162625/435289) |
| Branch Coverage | 37.85% (68746/181617) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3890385586
# FE Regression Coverage Report
Increment line coverage ` 55.56% (5/9)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_7d04b2c55fbe829e25ca2c317fe453a0321221bf_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_7d04b2c55fbe829e25ca2c317fe453a0321221bf_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3875515469
# BE UT Coverage Report
Increment line coverage `70.79% (143/202)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/a8e43c83f82838b364bf3f9a96cf38d1f074422c_a8e43c83f82838b364bf3f9a96cf38d1f074422c/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/a8e43c83f82838b364bf3f9a96cf38d1f074422c_a8e43c83f82838b364bf3f9a96cf38d1f074422c/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.77% (19479/36910) |
| Line Coverage | 36.24% (181329/500382) |
| Region Coverage | 32.62% (140926/431980) |
| Branch Coverage | 33.65% (61001/181297) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3855475769
# BE Regression && UT Coverage Report
Increment line coverage `92.59% (175/189)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_4d3741931e91c2c543f1ed8d076ff29efcc64a84_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_4d3741931e91c2c543f1ed8d076ff29efcc64a84_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.34% (26502/36137) |
| Line Coverage | 56.45% (281284/498278) |
| Region Coverage | 54.32% (236511/435400) |
| Branch Coverage | 55.84% (101442/181650) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3884653663
<details>
<summary>TPC-H: <b>Total hot run time: 30823 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7d04b2c55fbe829e25ca2c317fe453a0321221bf, data reload: false
------ Round 1 ----------------------------------
q1 17647 4559 4324 4324
q2 2049 384 240 240
q3 10114 1288 755 755
q4 10203 780 311 311
q5 7485 2221 1962 1962
q6 196 178 145 145
q7 883 753 598 598
q8 9290 1392 1240 1240
q9 4791 4708 4693 4693
q10 6798 1903 1537 1537
q11 441 255 242 242
q12 334 380 223 223
q13 17798 4077 3223 3223
q14 247 247 218 218
q15 876 811 802 802
q16 691 687 646 646
q17 712 805 543 543
q18 6506 5892 6132 5892
q19 1272 1123 644 644
q20 593 527 412 412
q21 2805 1963 1911 1911
q22 354 314 262 262
Total cold run time: 102085 ms
Total hot run time: 30823 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4653 4600 4731 4600
q2 264 353 247 247
q3 2325 3193 2439 2439
q4 1528 1837 1441 1441
q5 4674 4663 4655 4655
q6 224 174 136 136
q7 1970 1882 1841 1841
q8 2556 2394 2406 2394
q9 7795 7391 7461 7391
q10 2855 3074 2617 2617
q11 505 440 410 410
q12 723 790 620 620
q13 3825 4404 3530 3530
q14 268 284 277 277
q15 832 777 780 777
q16 643 724 623 623
q17 1101 1202 1275 1202
q18 7649 7442 7364 7364
q19 824 835 804 804
q20 1962 2030 1950 1950
q21 4535 4243 4068 4068
q22 495 442 442 442
Total cold run time: 52206 ms
Total hot run time: 49828 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3885643176
# BE Regression && UT Coverage Report
Increment line coverage `92.63% (176/190)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_7d04b2c55fbe829e25ca2c317fe453a0321221bf_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_7d04b2c55fbe829e25ca2c317fe453a0321221bf_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.75% (25956/36174) |
| Line Coverage | 54.38% (271628/499499) |
| Region Coverage | 51.67% (225367/436147) |
| Branch Coverage | 53.21% (96875/182068) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou merged PR #60310:
URL: https://github.com/apache/doris/pull/60310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3871215361
<details>
<summary>TPC-H: <b>Total hot run time: 30398 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a8e43c83f82838b364bf3f9a96cf38d1f074422c, data reload: false
------ Round 1 ----------------------------------
q1 17674 4520 4302 4302
q2 2038 353 233 233
q3 10151 1311 743 743
q4 10191 774 306 306
q5 7533 2202 1979 1979
q6 233 179 147 147
q7 865 722 620 620
q8 9276 1354 1101 1101
q9 4929 4685 4590 4590
q10 6868 1960 1568 1568
q11 543 305 280 280
q12 403 385 224 224
q13 17810 4101 3244 3244
q14 235 237 213 213
q15 891 820 793 793
q16 684 683 624 624
q17 688 763 618 618
q18 6865 6058 5782 5782
q19 1471 979 623 623
q20 516 488 381 381
q21 2529 1863 1748 1748
q22 357 312 279 279
Total cold run time: 102750 ms
Total hot run time: 30398 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4446 4331 4365 4331
q2 256 342 264 264
q3 2070 2682 2209 2209
q4 1347 1699 1266 1266
q5 4310 4139 4234 4139
q6 210 178 136 136
q7 1848 1771 1684 1684
q8 2615 2611 2383 2383
q9 7656 7717 7449 7449
q10 2945 3084 2605 2605
q11 539 495 439 439
q12 721 808 640 640
q13 3849 4451 3626 3626
q14 293 315 325 315
q15 910 827 835 827
q16 703 714 691 691
q17 1174 1323 1424 1323
q18 8274 7809 7905 7809
q19 934 827 843 827
q20 2154 2204 2016 2016
q21 4740 4298 4166 4166
q22 600 565 489 489
Total cold run time: 52594 ms
Total hot run time: 49634 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3875787597
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3875025940
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3852613857
<details>
<summary>TPC-H: <b>Total hot run time: 31824 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4d3741931e91c2c543f1ed8d076ff29efcc64a84, data reload: false
------ Round 1 ----------------------------------
q1 17618 4452 4275 4275
q2 2062 341 250 250
q3 10152 1384 743 743
q4 10255 863 315 315
q5 8632 2257 1912 1912
q6 209 179 145 145
q7 898 749 581 581
q8 9281 1482 1305 1305
q9 5581 4822 4874 4822
q10 6885 1984 1571 1571
q11 524 300 275 275
q12 405 382 225 225
q13 17799 4098 3254 3254
q14 234 243 227 227
q15 899 816 798 798
q16 695 675 623 623
q17 940 833 452 452
q18 6939 6765 7357 6765
q19 1451 1054 664 664
q20 415 398 266 266
q21 2959 2361 2072 2072
q22 376 322 284 284
Total cold run time: 105209 ms
Total hot run time: 31824 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4756 4686 4567 4567
q2 284 364 255 255
q3 2261 2889 2510 2510
q4 1489 1853 1413 1413
q5 4533 4524 4608 4524
q6 219 180 134 134
q7 1993 1972 1905 1905
q8 2610 2409 2398 2398
q9 7811 7427 7644 7427
q10 2862 2972 2643 2643
q11 551 485 437 437
q12 676 748 608 608
q13 3881 4267 3248 3248
q14 280 295 268 268
q15 828 774 778 774
q16 642 744 628 628
q17 1098 1313 1290 1290
q18 7416 7532 7356 7356
q19 838 793 815 793
q20 1977 2028 1874 1874
q21 4547 4140 4086 4086
q22 591 538 515 515
Total cold run time: 52143 ms
Total hot run time: 49653 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3853473206
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3854806350
run nonConcurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3819793082
<details>
<summary>ClickBench: <b>Total hot run time: 28.55 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 45e7d1fbb71cfe904b139878d2e4f80352f77f1a, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.04 0.05
query3 0.25 0.08 0.08
query4 1.60 0.11 0.11
query5 0.27 0.25 0.24
query6 1.16 0.67 0.66
query7 0.04 0.02 0.02
query8 0.04 0.04 0.04
query9 0.57 0.50 0.50
query10 0.57 0.54 0.55
query11 0.14 0.09 0.09
query12 0.13 0.10 0.11
query13 0.62 0.62 0.61
query14 1.06 1.07 1.05
query15 0.88 0.85 0.86
query16 0.38 0.39 0.38
query17 1.17 1.10 1.07
query18 0.22 0.20 0.21
query19 2.06 2.00 1.98
query20 0.02 0.02 0.02
query21 15.41 0.28 0.15
query22 4.91 0.06 0.05
query23 15.91 0.30 0.10
query24 0.90 0.76 0.31
query25 0.09 0.06 0.07
query26 0.14 0.13 0.14
query27 0.08 0.05 0.06
query28 3.56 1.18 0.96
query29 12.55 3.88 3.13
query30 0.28 0.14 0.11
query31 2.81 0.64 0.39
query32 3.27 0.60 0.50
query33 3.18 3.24 3.27
query34 16.64 5.38 4.70
query35 4.76 5.14 5.41
query36 0.68 0.56 0.55
query37 0.11 0.08 0.06
query38 0.07 0.04 0.04
query39 0.04 0.03 0.03
query40 0.22 0.17 0.15
query41 0.08 0.02 0.02
query42 0.04 0.02 0.02
query43 0.05 0.04 0.03
Total cold run time: 97.11 s
Total hot run time: 28.55 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3846882469
<details>
<summary>ClickBench: <b>Total hot run time: 28.19 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0084d8c94efd40698d8591000d2f64d7f07404c7, data reload: false
query1 0.05 0.04 0.05
query2 0.14 0.07 0.07
query3 0.30 0.08 0.08
query4 1.60 0.10 0.10
query5 0.25 0.25 0.25
query6 1.14 0.65 0.64
query7 0.03 0.03 0.03
query8 0.09 0.06 0.06
query9 0.58 0.51 0.50
query10 0.54 0.56 0.55
query11 0.26 0.14 0.13
query12 0.26 0.14 0.14
query13 0.62 0.62 0.60
query14 0.99 0.98 0.99
query15 0.92 0.83 0.83
query16 0.41 0.40 0.43
query17 1.12 1.07 1.05
query18 0.25 0.23 0.22
query19 1.92 1.91 1.84
query20 0.02 0.02 0.02
query21 15.42 0.34 0.29
query22 4.98 0.12 0.11
query23 15.35 0.42 0.26
query24 2.36 0.56 0.39
query25 0.11 0.11 0.11
query26 0.19 0.18 0.18
query27 0.11 0.10 0.10
query28 3.60 1.14 0.97
query29 12.52 4.00 3.26
query30 0.34 0.13 0.11
query31 2.79 0.69 0.44
query32 3.24 0.62 0.51
query33 3.07 3.04 2.97
query34 16.01 5.06 4.44
query35 4.50 4.53 4.48
query36 0.62 0.51 0.49
query37 0.31 0.09 0.09
query38 0.26 0.06 0.06
query39 0.08 0.04 0.04
query40 0.21 0.18 0.17
query41 0.13 0.08 0.07
query42 0.09 0.05 0.05
query43 0.09 0.08 0.07
Total cold run time: 97.87 s
Total hot run time: 28.19 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [DO NOT MERGE]JUST TEST [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3810162434
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3822797603
<details>
<summary>TPC-H: <b>Total hot run time: 31948 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 006d993f151aa35a8607afc0d9941d132aa8033e, data reload: false
------ Round 1 ----------------------------------
q1 17643 5268 5067 5067
q2 2043 316 200 200
q3 10193 1313 767 767
q4 10211 889 327 327
q5 7530 2137 1947 1947
q6 196 179 148 148
q7 894 740 608 608
q8 9254 1421 1145 1145
q9 5419 4884 4904 4884
q10 6912 1974 1568 1568
q11 536 295 279 279
q12 378 387 236 236
q13 17770 4080 3218 3218
q14 249 253 227 227
q15 920 850 807 807
q16 695 677 641 641
q17 635 797 505 505
q18 7090 6506 6371 6371
q19 1442 995 614 614
q20 390 356 237 237
q21 2720 2086 1875 1875
q22 374 324 277 277
Total cold run time: 103494 ms
Total hot run time: 31948 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5409 5295 5316 5295
q2 260 342 256 256
q3 2187 2668 2245 2245
q4 1356 1724 1308 1308
q5 4258 4194 4304 4194
q6 220 188 145 145
q7 2419 2043 1845 1845
q8 2582 2441 2429 2429
q9 7589 7357 7624 7357
q10 2820 2979 2653 2653
q11 614 478 476 476
q12 742 764 644 644
q13 3904 4381 3539 3539
q14 323 338 309 309
q15 863 820 872 820
q16 683 731 677 677
q17 1213 1651 1398 1398
q18 8254 7783 7699 7699
q19 926 889 989 889
q20 2121 2251 2053 2053
q21 4814 4386 4139 4139
q22 586 549 540 540
Total cold run time: 54143 ms
Total hot run time: 50910 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3819089480
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3853473007
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3854805502
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3852707081
<details>
<summary>ClickBench: <b>Total hot run time: 28.94 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4d3741931e91c2c543f1ed8d076ff29efcc64a84, data reload: false
query1 0.05 0.04 0.04
query2 0.10 0.05 0.04
query3 0.26 0.09 0.08
query4 1.60 0.11 0.11
query5 0.27 0.25 0.25
query6 1.17 0.67 0.66
query7 0.02 0.02 0.02
query8 0.05 0.05 0.04
query9 0.56 0.50 0.49
query10 0.53 0.55 0.56
query11 0.15 0.10 0.10
query12 0.15 0.10 0.11
query13 0.63 0.61 0.61
query14 1.06 1.06 1.06
query15 0.88 0.87 0.87
query16 0.40 0.41 0.40
query17 1.14 1.16 1.16
query18 0.23 0.21 0.21
query19 2.02 1.96 2.00
query20 0.02 0.01 0.01
query21 15.42 0.27 0.15
query22 5.27 0.06 0.05
query23 16.02 0.29 0.11
query24 1.38 1.33 0.21
query25 0.10 0.07 0.06
query26 0.15 0.14 0.14
query27 0.06 0.05 0.06
query28 4.71 1.15 0.97
query29 12.58 4.02 3.22
query30 0.27 0.13 0.12
query31 2.81 0.64 0.40
query32 3.24 0.59 0.50
query33 3.39 3.25 3.30
query34 16.31 5.36 4.75
query35 4.71 5.67 5.29
query36 0.68 0.56 0.53
query37 0.11 0.07 0.08
query38 0.07 0.04 0.04
query39 0.04 0.03 0.03
query40 0.19 0.18 0.16
query41 0.09 0.03 0.03
query42 0.04 0.02 0.04
query43 0.04 0.04 0.03
Total cold run time: 98.97 s
Total hot run time: 28.94 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3846804631
<details>
<summary>TPC-H: <b>Total hot run time: 31957 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0084d8c94efd40698d8591000d2f64d7f07404c7, data reload: false
------ Round 1 ----------------------------------
q1 17666 5276 5121 5121
q2 2033 339 206 206
q3 10507 1322 772 772
q4 10335 844 307 307
q5 9508 2230 1913 1913
q6 226 180 147 147
q7 880 746 608 608
q8 9269 1431 1108 1108
q9 5512 4896 4871 4871
q10 6873 1945 1553 1553
q11 513 294 281 281
q12 394 376 229 229
q13 17799 4071 3261 3261
q14 238 238 217 217
q15 921 819 817 817
q16 674 676 636 636
q17 651 794 505 505
q18 6725 6651 6367 6367
q19 1098 1015 624 624
q20 382 354 236 236
q21 2627 2078 1904 1904
q22 360 312 274 274
Total cold run time: 105191 ms
Total hot run time: 31957 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5339 5294 5316 5294
q2 279 334 254 254
q3 2161 2677 2300 2300
q4 1345 1726 1316 1316
q5 4248 4209 4623 4209
q6 252 221 160 160
q7 2203 1980 1895 1895
q8 2652 2556 2443 2443
q9 7470 7552 7316 7316
q10 2936 3002 2575 2575
q11 560 506 450 450
q12 719 742 634 634
q13 3940 4253 3528 3528
q14 297 315 298 298
q15 920 841 812 812
q16 705 726 678 678
q17 1153 1314 1356 1314
q18 8234 8041 7966 7966
q19 886 926 1048 926
q20 2114 2183 2027 2027
q21 4727 4248 4136 4136
q22 580 585 525 525
Total cold run time: 53720 ms
Total hot run time: 51056 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3846117074
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3867556132
### Code review
Found 1 issue:
1. Missing `has_mtime()` check when accessing `cluster.mtime()` in `get_cluster_status()`. On the server side (`meta_service_resource.cpp`), `mtime` is conditionally set only when `cluster.has_mtime()` is true. When it is not set, protobuf3 returns the default value `0`, so `0 * 1000 = 0` is stored as `mtime_ms` in the `ClusterStatusCache`. Downstream in `should_skip_compaction()`, the elapsed time is computed as `now - status_mtime`. When `status_mtime` is 0, `elapsed` equals the current Unix time in milliseconds (~1.7 trillion), which is always greater than the 5-minute takeover timeout. This causes immediate compaction takeover by non-writer clusters, bypassing the timeout safety mechanism entirely.
https://github.com/apache/doris/blob/4d3741931e91c2c543f1ed8d076ff29efcc64a84/be/src/cloud/cloud_meta_mgr.cpp#L2281-L2283
Server-side conditional setting that proves `mtime` is optional:
https://github.com/apache/doris/blob/4d3741931e91c2c543f1ed8d076ff29efcc64a84/cloud/src/meta-service/meta_service_resource.cpp#L4587-L4589
Downstream timeout bypass when `mtime_ms` is 0:
https://github.com/apache/doris/blob/4d3741931e91c2c543f1ed8d076ff29efcc64a84/be/src/cloud/cloud_cluster_info.cpp#L166-L180
🤖 Generated with [Claude Code](https://claude.ai/code)
<sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3875027151
run beut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3850872584
run nonConcurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3850872842
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3851806862
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3821698749
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3876293506
# BE Regression && UT Coverage Report
Increment line coverage `92.63% (176/190)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_a8e43c83f82838b364bf3f9a96cf38d1f074422c_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_a8e43c83f82838b364bf3f9a96cf38d1f074422c_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.45% (26553/36151) |
| Line Coverage | 56.47% (281724/498851) |
| Region Coverage | 54.08% (235820/436076) |
| Branch Coverage | 55.81% (101479/181835) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3890340830
# BE Regression && UT Coverage Report
Increment line coverage `93.78% (181/193)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_7d04b2c55fbe829e25ca2c317fe453a0321221bf_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_7d04b2c55fbe829e25ca2c317fe453a0321221bf_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.74% (25950/36174) |
| Line Coverage | 54.36% (271540/499499) |
| Region Coverage | 51.62% (225153/436147) |
| Branch Coverage | 53.19% (96847/182068) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3857777353
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3818718283
# FE UT Coverage Report
Increment line coverage `` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_23e382553c330d98967cad3ae0497e1dab38adaa/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_23e382553c330d98967cad3ae0497e1dab38adaa/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [DO NOT MERGE]JUST TEST [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3818109689
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3840800464
<details>
<summary>TPC-H: <b>Total hot run time: 32217 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 159ab4d7cbe585e36ff37f1f25f93c83b22ff4b5, data reload: false
------ Round 1 ----------------------------------
q1 17627 5273 5128 5128
q2 2054 309 199 199
q3 10609 1328 747 747
q4 10319 802 321 321
q5 9573 2139 1970 1970
q6 246 183 150 150
q7 936 744 596 596
q8 9268 1392 1076 1076
q9 5334 4853 4872 4853
q10 6856 1970 1571 1571
q11 525 286 275 275
q12 410 373 223 223
q13 17802 4081 3268 3268
q14 230 237 229 229
q15 928 830 808 808
q16 659 682 628 628
q17 659 803 503 503
q18 6935 6578 6542 6542
q19 1147 996 625 625
q20 400 347 232 232
q21 2623 2076 2003 2003
q22 357 323 270 270
Total cold run time: 105497 ms
Total hot run time: 32217 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5397 5327 5337 5327
q2 256 331 240 240
q3 2163 2677 2264 2264
q4 1338 1714 1315 1315
q5 4295 4215 4817 4215
q6 237 200 159 159
q7 2166 1948 1875 1875
q8 2595 2506 2385 2385
q9 7580 7399 7517 7399
q10 2886 3077 2614 2614
q11 562 488 449 449
q12 765 753 616 616
q13 4048 4252 3563 3563
q14 327 331 310 310
q15 997 904 856 856
q16 693 735 678 678
q17 1184 1361 1640 1361
q18 8007 7832 7792 7792
q19 915 874 865 865
q20 2194 2179 1915 1915
q21 4522 4193 4146 4146
q22 582 548 511 511
Total cold run time: 53709 ms
Total hot run time: 50855 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3871285053
<details>
<summary>ClickBench: <b>Total hot run time: 28.34 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a8e43c83f82838b364bf3f9a96cf38d1f074422c, data reload: false
query1 0.05 0.04 0.04
query2 0.14 0.07 0.06
query3 0.35 0.08 0.08
query4 1.60 0.10 0.10
query5 0.26 0.25 0.24
query6 1.15 0.65 0.65
query7 0.02 0.02 0.02
query8 0.07 0.06 0.06
query9 0.59 0.51 0.50
query10 0.54 0.55 0.55
query11 0.26 0.14 0.14
query12 0.26 0.15 0.14
query13 0.63 0.62 0.59
query14 0.98 0.99 0.97
query15 0.91 0.83 0.83
query16 0.38 0.39 0.40
query17 1.05 1.03 1.06
query18 0.24 0.22 0.23
query19 1.93 1.88 1.88
query20 0.02 0.02 0.01
query21 15.44 0.34 0.30
query22 4.99 0.13 0.13
query23 15.34 0.45 0.29
query24 2.40 0.58 0.42
query25 0.12 0.11 0.11
query26 0.19 0.18 0.19
query27 0.11 0.11 0.12
query28 3.72 1.16 1.00
query29 12.53 4.10 3.32
query30 0.33 0.13 0.10
query31 2.81 0.69 0.44
query32 3.23 0.63 0.50
query33 3.00 3.07 3.10
query34 16.42 5.04 4.47
query35 4.53 4.39 4.58
query36 0.61 0.49 0.49
query37 0.31 0.10 0.09
query38 0.28 0.06 0.06
query39 0.08 0.04 0.04
query40 0.23 0.17 0.17
query41 0.15 0.07 0.07
query42 0.09 0.05 0.04
query43 0.06 0.06 0.05
Total cold run time: 98.4 s
Total hot run time: 28.34 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3847287924
# BE Regression && UT Coverage Report
Increment line coverage `91.01% (172/189)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_0084d8c94efd40698d8591000d2f64d7f07404c7_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_0084d8c94efd40698d8591000d2f64d7f07404c7_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.33% (26495/36131) |
| Line Coverage | 56.45% (281229/498180) |
| Region Coverage | 54.32% (236497/435351) |
| Branch Coverage | 55.81% (101359/181615) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3846270317
# Cloud UT Coverage Report
Increment line coverage `68.89% (62/90)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/0084d8c94efd40698d8591000d2f64d7f07404c7_0084d8c94efd40698d8591000d2f64d7f07404c7_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/0084d8c94efd40698d8591000d2f64d7f07404c7_0084d8c94efd40698d8591000d2f64d7f07404c7_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.30% (1793/2261) |
| Line Coverage | 64.76% (31895/49251) |
| Region Coverage | 65.43% (15929/24344) |
| Branch Coverage | 55.91% (8461/15134) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3858140367
# BE Regression && UT Coverage Report
Increment line coverage `92.59% (175/189)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_4d3741931e91c2c543f1ed8d076ff29efcc64a84_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_4d3741931e91c2c543f1ed8d076ff29efcc64a84_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.34% (26504/36137) |
| Line Coverage | 56.45% (281302/498278) |
| Region Coverage | 54.34% (236579/435400) |
| Branch Coverage | 55.85% (101443/181650) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3889377134
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3858817958
# BE Regression && UT Coverage Report
Increment line coverage `92.59% (175/189)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_4d3741931e91c2c543f1ed8d076ff29efcc64a84_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_4d3741931e91c2c543f1ed8d076ff29efcc64a84_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.31% (26491/36137) |
| Line Coverage | 56.42% (281124/498278) |
| Region Coverage | 54.30% (236432/435400) |
| Branch Coverage | 55.81% (101385/181650) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3851184080
# BE Regression && UT Coverage Report
Increment line coverage `91.01% (172/189)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_0084d8c94efd40698d8591000d2f64d7f07404c7_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_0084d8c94efd40698d8591000d2f64d7f07404c7_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.39% (26515/36131) |
| Line Coverage | 56.50% (281470/498180) |
| Region Coverage | 54.36% (236644/435351) |
| Branch Coverage | 55.89% (101501/181615) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3858390450
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3875526410
# BE Regression && UT Coverage Report
Increment line coverage `92.63% (176/190)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_a8e43c83f82838b364bf3f9a96cf38d1f074422c_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_a8e43c83f82838b364bf3f9a96cf38d1f074422c_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.48% (26564/36151) |
| Line Coverage | 56.51% (281884/498851) |
| Region Coverage | 54.10% (235928/436076) |
| Branch Coverage | 55.83% (101527/181835) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3869948888
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3870187198
# Cloud UT Coverage Report
Increment line coverage `68.89% (62/90)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/a8e43c83f82838b364bf3f9a96cf38d1f074422c_a8e43c83f82838b364bf3f9a96cf38d1f074422c_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/a8e43c83f82838b364bf3f9a96cf38d1f074422c_a8e43c83f82838b364bf3f9a96cf38d1f074422c_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.36% (1796/2263) |
| Line Coverage | 64.88% (32024/49362) |
| Region Coverage | 65.58% (15992/24387) |
| Branch Coverage | 56.04% (8502/15170) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3875027584
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3823140407
# BE UT Coverage Report
Increment line coverage `53.72% (101/188)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/006d993f151aa35a8607afc0d9941d132aa8033e_006d993f151aa35a8607afc0d9941d132aa8033e/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/006d993f151aa35a8607afc0d9941d132aa8033e_006d993f151aa35a8607afc0d9941d132aa8033e/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.50% (19284/36732) |
| Line Coverage | 35.98% (179184/497968) |
| Region Coverage | 32.43% (139235/429311) |
| Branch Coverage | 33.34% (60124/180347) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3884271500
# Cloud UT Coverage Report
Increment line coverage `51.72% (30/58)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/7d04b2c55fbe829e25ca2c317fe453a0321221bf_7d04b2c55fbe829e25ca2c317fe453a0321221bf_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/7d04b2c55fbe829e25ca2c317fe453a0321221bf_7d04b2c55fbe829e25ca2c317fe453a0321221bf_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.33% (1796/2264) |
| Line Coverage | 64.86% (32015/49361) |
| Region Coverage | 65.55% (15974/24369) |
| Branch Coverage | 56.04% (8494/15156) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3884934572
# BE UT Coverage Report
Increment line coverage `70.79% (143/202)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/7d04b2c55fbe829e25ca2c317fe453a0321221bf_7d04b2c55fbe829e25ca2c317fe453a0321221bf/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/7d04b2c55fbe829e25ca2c317fe453a0321221bf_7d04b2c55fbe829e25ca2c317fe453a0321221bf/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.79% (19490/36922) |
| Line Coverage | 36.26% (181551/500750) |
| Region Coverage | 32.64% (140934/431771) |
| Branch Coverage | 33.65% (61030/181364) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3889720624
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3881875800
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3853519273
# BE Regression && UT Coverage Report
Increment line coverage `92.59% (175/189)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_4d3741931e91c2c543f1ed8d076ff29efcc64a84_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_4d3741931e91c2c543f1ed8d076ff29efcc64a84_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.32% (26495/36137) |
| Line Coverage | 56.42% (281139/498278) |
| Region Coverage | 54.31% (236478/435400) |
| Branch Coverage | 55.82% (101396/181650) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3889148695
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #60310:
URL: https://github.com/apache/doris/pull/60310#discussion_r2744772074
##########
cloud/src/meta-store/keys.h:
##########
@@ -160,7 +160,7 @@ using TxnInfoKeyInfo = BasicKeyInfo<__LINE__ , std::tuple<std::string, in
// 0:instance_id 1:txn_id
using TxnIndexKeyInfo = BasicKeyInfo<__LINE__ , std::tuple<std::string, int64_t>>;
-// 0:instance_id 1:db_id 2:txn_id
Review Comment:
do not touch what you dont modify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3820726119
# BE Regression && UT Coverage Report
Increment line coverage `43.62% (82/188)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_45e7d1fbb71cfe904b139878d2e4f80352f77f1a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_45e7d1fbb71cfe904b139878d2e4f80352f77f1a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.49% (25620/35836) |
| Line Coverage | 54.12% (267758/494727) |
| Region Coverage | 51.71% (222948/431184) |
| Branch Coverage | 53.15% (95741/180137) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3822635633
# FE UT Coverage Report
Increment line coverage `` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_006d993f151aa35a8607afc0d9941d132aa8033e/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_006d993f151aa35a8607afc0d9941d132aa8033e/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3852070652
# Cloud UT Coverage Report
Increment line coverage `68.89% (62/90)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/4d3741931e91c2c543f1ed8d076ff29efcc64a84_4d3741931e91c2c543f1ed8d076ff29efcc64a84_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/4d3741931e91c2c543f1ed8d076ff29efcc64a84_4d3741931e91c2c543f1ed8d076ff29efcc64a84_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.30% (1793/2261) |
| Line Coverage | 64.77% (31899/49251) |
| Region Coverage | 65.41% (15923/24344) |
| Branch Coverage | 55.91% (8462/15134) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60310:
URL: https://github.com/apache/doris/pull/60310#issuecomment-3855304119
# BE Regression && UT Coverage Report
Increment line coverage `92.59% (175/189)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60310_4d3741931e91c2c543f1ed8d076ff29efcc64a84_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60310_4d3741931e91c2c543f1ed8d076ff29efcc64a84_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.32% (26495/36137) |
| Line Coverage | 56.42% (281139/498278) |
| Region Coverage | 54.31% (236478/435400) |
| Branch Coverage | 55.82% (101396/181650) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](cloud) Support compaction read-write separation for cloud mode [doris]
Posted by "luwei16 (via GitHub)" <gi...@apache.org>.
luwei16 commented on code in PR #60310:
URL: https://github.com/apache/doris/pull/60310#discussion_r2758913568
##########
be/src/cloud/cloud_tablet_mgr.cpp:
##########
@@ -426,6 +426,12 @@ Status CloudTabletMgr::get_topn_tablets_to_compact(
auto now = duration_cast<milliseconds>(system_clock::now().time_since_epoch()).count();
auto skip = [now, compaction_type](CloudTablet* t) {
auto* cloud_cluster_info = static_cast<CloudClusterInfo*>(ExecEnv::GetInstance()->cluster_info());
+
+ // Compaction read-write separation: skip tablets that should be compacted by other clusters
Review Comment:
// Placing this check here violates the invariant that the standby cluster must not perform compaction in some scenarios.
##########
be/src/cloud/cloud_tablet_mgr.cpp:
##########
@@ -426,6 +426,12 @@ Status CloudTabletMgr::get_topn_tablets_to_compact(
auto now = duration_cast<milliseconds>(system_clock::now().time_since_epoch()).count();
auto skip = [now, compaction_type](CloudTablet* t) {
auto* cloud_cluster_info = static_cast<CloudClusterInfo*>(ExecEnv::GetInstance()->cluster_info());
+
+ // Compaction read-write separation: skip tablets that should be compacted by other clusters
Review Comment:
Placing this check here violates the invariant that the standby cluster must not perform compaction in some scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org