You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/03/19 01:41:33 UTC
[jira] [Commented] (CB-9911) coho update-release-notes doesn't work
for cordova common
[ https://issues.apache.org/jira/browse/CB-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202422#comment-15202422 ]
ASF subversion and git services commented on CB-9911:
-----------------------------------------------------
Commit 532f027c65f7bb93d3b97a204c4bdd3727249e5b in cordova-coho's branch refs/heads/master from [~stevegill]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-coho.git;h=532f027 ]
CB-9911 update-release-notes now handles prefixed tags
> coho update-release-notes doesn't work for cordova common
> ---------------------------------------------------------
>
> Key: CB-9911
> URL: https://issues.apache.org/jira/browse/CB-9911
> Project: Apache Cordova
> Issue Type: Bug
> Components: Coho
> Reporter: Steve Gill
> Assignee: Steve Gill
>
> Issue is in the findMostRecentTag function in gitutil.js.
> It goes through all of the tags in cordova-lib sequentially. This works fine for cordova-serve because they are last on the list. The logic works fine for cordova-common but then the reduce continues onto other git tags. It eventually returns null as that is the result of the final reduce (Which is done a serve tag).
> Here is some output of the execution of reduce.
> PREFIX: common-
> other tags: 0.21.11
> other tags: 0.21.12
> other tags: 0.21.13
> other tags: 0.21.2
> other tags: 0.21.4
> other tags: 0.21.5-rc1
> other tags: 0.21.6
> other tags: 0.21.6-rc1
> other tags: 0.21.6-rc2
> other tags: 0.21.6-rc3
> other tags: 0.21.7
> other tags: 0.21.7-rc1
> other tags: 0.21.8
> other tags: 0.21.9
> other tags: 3.7.0
> other tags: 4.0.0
> other tags: 4.1.1
> other tags: 4.1.2
> other tags: 4.2.0
> other tags: 4.3.0
> other tags: 4.3.1
> other tags: 5.0.0
> other tags: 5.1.1
> other tags: 5.2.0
> other tags: 5.3.1
> other tags: 5.3.2
> other tags: 5.3.3
> other tags: cli_pre_lib
> 1.0.0 common-1.0.0 null null (modValue, value, modCurBest, curBest)
> if common-1.0.0
> returning
> other tags: cordova-lib-0.21.3
> other tags: pg.3.5.0
> other tags: plugman_pre_lib
> other tags: serve-0.1.2
> other tags: serve-0.1.3
> other tags: serve-1.0.0
> null
> As you can see, it returns null because the final item in the list is serve-1.0.0 when the return I want happened above.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org